2021-05-29 03:54:32

by Baokun Li

Subject: [PATCH -next] w1: ds1wm: Remove set but not used variable 'inten'

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/w1/masters/ds1wm.c: In function 'ds1wm_probe':
drivers/w1/masters/ds1wm.c:512:5: warning:
variable ‘inten’ set but not used [-Wunused-but-set-variable]

It never used since introduction.

Signed-off-by: Baokun Li <[email protected]>
---
drivers/w1/masters/ds1wm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/w1/masters/ds1wm.c b/drivers/w1/masters/ds1wm.c
index f661695fb589..f59d92865ecb 100644
--- a/drivers/w1/masters/ds1wm.c
+++ b/drivers/w1/masters/ds1wm.c
@@ -509,7 +509,6 @@ static int ds1wm_probe(struct platform_device *pdev)
struct ds1wm_driver_data *plat;
struct resource *res;
int ret;
- u8 inten;

if (!pdev)
return -ENODEV;
@@ -564,7 +563,7 @@ static int ds1wm_probe(struct platform_device *pdev)
ds1wm_data->reset_recover_delay = plat->reset_recover_delay;

/* Mask interrupts, set IAS before claiming interrupt */
- inten = ds1wm_read_register(ds1wm_data, DS1WM_INT_EN);
+ ds1wm_read_register(ds1wm_data, DS1WM_INT_EN);
ds1wm_write_register(ds1wm_data,
DS1WM_INT_EN, ds1wm_data->int_en_reg_none);

--
2.25.4

2021-06-15 02:43:44

by Baokun Li

Subject: Re: [PATCH -next] w1: ds1wm: Remove set but not used variable 'inten'

ping

在 2021/5/29 11:59, Baokun Li 写道:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/w1/masters/ds1wm.c: In function 'ds1wm_probe':
> drivers/w1/masters/ds1wm.c:512:5: warning:
> variable ‘inten’ set but not used [-Wunused-but-set-variable]
>
> It never used since introduction.
>
> Signed-off-by: Baokun Li <[email protected]>
> ---
> drivers/w1/masters/ds1wm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/w1/masters/ds1wm.c b/drivers/w1/masters/ds1wm.c
> index f661695fb589..f59d92865ecb 100644
> --- a/drivers/w1/masters/ds1wm.c
> +++ b/drivers/w1/masters/ds1wm.c
> @@ -509,7 +509,6 @@ static int ds1wm_probe(struct platform_device *pdev)
> struct ds1wm_driver_data *plat;
> struct resource *res;
> int ret;
> - u8 inten;
>
> if (!pdev)
> return -ENODEV;
> @@ -564,7 +563,7 @@ static int ds1wm_probe(struct platform_device *pdev)
> ds1wm_data->reset_recover_delay = plat->reset_recover_delay;
>
> /* Mask interrupts, set IAS before claiming interrupt */
> - inten = ds1wm_read_register(ds1wm_data, DS1WM_INT_EN);
> + ds1wm_read_register(ds1wm_data, DS1WM_INT_EN);
> ds1wm_write_register(ds1wm_data,
> DS1WM_INT_EN, ds1wm_data->int_en_reg_none);
>