2019-11-22 10:18:41

by Benjamin GAIGNARD

Subject: [PATCH v3] dt-bindings: watchdog: Convert stm32 watchdog bindings to json-schema

Convert the STM32 watchdog binding to DT schema format using json-schema

Signed-off-by: Benjamin Gaignard <[email protected]>
---
changes in version 3:
- fix typo in clock-names enum

changes in version 2:
- remove trailer space
- add Christophe in the maintainers list

.../devicetree/bindings/watchdog/st,stm32-iwdg.txt | 26 ----------
.../bindings/watchdog/st,stm32-iwdg.yaml | 55 ++++++++++++++++++++++
2 files changed, 55 insertions(+), 26 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.txt
create mode 100644 Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.yaml

diff --git a/Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.txt b/Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.txt
deleted file mode 100644
index d8f4430b0a13..000000000000
--- a/Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.txt
+++ /dev/null
@@ -1,26 +0,0 @@
-STM32 Independent WatchDoG (IWDG)
----------------------------------
-
-Required properties:
-- compatible: Should be either:
- - "st,stm32-iwdg"
- - "st,stm32mp1-iwdg"
-- reg: Physical base address and length of the registers set for the device
-- clocks: Reference to the clock entry lsi. Additional pclk clock entry
- is required only for st,stm32mp1-iwdg.
-- clock-names: Name of the clocks used.
- "lsi" for st,stm32-iwdg
- "lsi", "pclk" for st,stm32mp1-iwdg
-
-Optional Properties:
-- timeout-sec: Watchdog timeout value in seconds.
-
-Example:
-
-iwdg: watchdog@40003000 {
- compatible = "st,stm32-iwdg";
- reg = <0x40003000 0x400>;
- clocks = <&clk_lsi>;
- clock-names = "lsi";
- timeout-sec = <32>;
-};
diff --git a/Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.yaml b/Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.yaml
new file mode 100644
index 000000000000..928588091710
--- /dev/null
+++ b/Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.yaml
@@ -0,0 +1,55 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/watchdog/st,stm32-iwdg.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: STMicroelectronics STM32 Independent WatchDoG (IWDG) bindings
+
+maintainers:
+ - Yannick Fertre <[email protected]>
+ - Christophe Roullier <[email protected]>
+
+allOf:
+ - $ref: "watchdog.yaml#"
+
+properties:
+ compatible:
+ enum:
+ - st,stm32-iwdg
+ - st,stm32mp1-iwdg
+
+ reg:
+ maxItems: 1
+
+ clocks:
+ items:
+ - description: Low speed clock
+ - description: Optional peripheral clock
+ minItems: 1
+ maxItems: 2
+
+ clock-names:
+ items:
+ enum: [ lsi, pclk ]
+ minItems: 1
+ maxItems: 2
+
+required:
+ - compatible
+ - reg
+ - clocks
+ - clock-names
+
+examples:
+ - |
+ #include <dt-bindings/clock/stm32mp1-clks.h>
+ watchdog@5a002000 {
+ compatible = "st,stm32mp1-iwdg";
+ reg = <0x5a002000 0x400>;
+ clocks = <&rcc IWDG2>, <&rcc CK_LSI>;
+ clock-names = "pclk", "lsi";
+ timeout-sec = <32>;
+ };
+
+...
--
2.15.0

2019-12-10 08:30:12

by Benjamin GAIGNARD

Subject: Re: [PATCH v3] dt-bindings: watchdog: Convert stm32 watchdog bindings to json-schema

On 11/22/19 11:16 AM, Benjamin Gaignard wrote:
> Convert the STM32 watchdog binding to DT schema format using json-schema

gentle ping to reviewers,

Thanks,

Benjamin

> Signed-off-by: Benjamin Gaignard <[email protected]>
> ---
> changes in version 3:
> - fix typo in clock-names enum
>
> changes in version 2:
> - remove trailer space
> - add Christophe in the maintainers list
>
> .../devicetree/bindings/watchdog/st,stm32-iwdg.txt | 26 ----------
> .../bindings/watchdog/st,stm32-iwdg.yaml | 55 ++++++++++++++++++++++
> 2 files changed, 55 insertions(+), 26 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.txt
> create mode 100644 Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.yaml
>
> diff --git a/Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.txt b/Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.txt
> deleted file mode 100644
> index d8f4430b0a13..000000000000
> --- a/Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.txt
> +++ /dev/null
> @@ -1,26 +0,0 @@
> -STM32 Independent WatchDoG (IWDG)
> ----------------------------------
> -
> -Required properties:
> -- compatible: Should be either:
> - - "st,stm32-iwdg"
> - - "st,stm32mp1-iwdg"
> -- reg: Physical base address and length of the registers set for the device
> -- clocks: Reference to the clock entry lsi. Additional pclk clock entry
> - is required only for st,stm32mp1-iwdg.
> -- clock-names: Name of the clocks used.
> - "lsi" for st,stm32-iwdg
> - "lsi", "pclk" for st,stm32mp1-iwdg
> -
> -Optional Properties:
> -- timeout-sec: Watchdog timeout value in seconds.
> -
> -Example:
> -
> -iwdg: watchdog@40003000 {
> - compatible = "st,stm32-iwdg";
> - reg = <0x40003000 0x400>;
> - clocks = <&clk_lsi>;
> - clock-names = "lsi";
> - timeout-sec = <32>;
> -};
> diff --git a/Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.yaml b/Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.yaml
> new file mode 100644
> index 000000000000..928588091710
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.yaml
> @@ -0,0 +1,55 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/st,stm32-iwdg.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: STMicroelectronics STM32 Independent WatchDoG (IWDG) bindings
> +
> +maintainers:
> + - Yannick Fertre <[email protected]>
> + - Christophe Roullier <[email protected]>
> +
> +allOf:
> + - $ref: "watchdog.yaml#"
> +
> +properties:
> + compatible:
> + enum:
> + - st,stm32-iwdg
> + - st,stm32mp1-iwdg
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: Low speed clock
> + - description: Optional peripheral clock
> + minItems: 1
> + maxItems: 2
> +
> + clock-names:
> + items:
> + enum: [ lsi, pclk ]
> + minItems: 1
> + maxItems: 2
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/stm32mp1-clks.h>
> + watchdog@5a002000 {
> + compatible = "st,stm32mp1-iwdg";
> + reg = <0x5a002000 0x400>;
> + clocks = <&rcc IWDG2>, <&rcc CK_LSI>;
> + clock-names = "pclk", "lsi";
> + timeout-sec = <32>;
> + };
> +
> +...