2017-04-14 13:58:09

by Colin King

Subject: [PATCH] scsi: fc: remove redundant check of an unsigned long being less than zero

From: Colin Ian King <[email protected]>

The check for an unsigned long being less than zero is always false
so it is a redundant check and can be removed.

Detected by static analysis with by PVS-Studio

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/scsi/scsi_transport_fc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c
index 2d753c93e07a..87b8f9d64d9b 100644
--- a/drivers/scsi/scsi_transport_fc.c
+++ b/drivers/scsi/scsi_transport_fc.c
@@ -850,7 +850,7 @@ static int fc_str_to_dev_loss(const char *buf, unsigned long *val)
char *cp;

*val = simple_strtoul(buf, &cp, 0);
- if ((*cp && (*cp != '\n')) || (*val < 0))
+ if (*cp && (*cp != '\n'))
return -EINVAL;
/*
* Check for overflow; dev_loss_tmo is u32
--
2.11.0

2017-04-17 18:53:07

by Tyrel Datwyler

Subject: Re: [PATCH] scsi: fc: remove redundant check of an unsigned long being less than zero

On 04/14/2017 06:58 AM, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The check for an unsigned long being less than zero is always false
> so it is a redundant check and can be removed.
>
> Detected by static analysis with by PVS-Studio
>
> Signed-off-by: Colin Ian King <[email protected]>

Reviewed-by: Tyrel Datwyler <[email protected]>

> ---
> drivers/scsi/scsi_transport_fc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c
> index 2d753c93e07a..87b8f9d64d9b 100644
> --- a/drivers/scsi/scsi_transport_fc.c
> +++ b/drivers/scsi/scsi_transport_fc.c
> @@ -850,7 +850,7 @@ static int fc_str_to_dev_loss(const char *buf, unsigned long *val)
> char *cp;
>
> *val = simple_strtoul(buf, &cp, 0);
> - if ((*cp && (*cp != '\n')) || (*val < 0))
> + if (*cp && (*cp != '\n'))
> return -EINVAL;
> /*
> * Check for overflow; dev_loss_tmo is u32
>

2017-04-19 01:54:22

by Martin K. Petersen

Subject: Re: [PATCH] scsi: fc: remove redundant check of an unsigned long being less than zero

Colin King <[email protected]> writes:

> The check for an unsigned long being less than zero is always false so
> it is a redundant check and can be removed.

Applied to 4.12/scsi-queue.

--
Martin K. Petersen Oracle Linux Engineering