2021-11-29 06:35:56

by Cai,Huoqing

Subject: [PATCH] drm/tidss: Fix warning: unused variable 'tidss_pm_ops'

Mark 'tidss_pm_ops' as __maybe_unused to avoid
the warning: unused variable 'tidss_pm_ops'

Fixes: 6e120594631f ("drm/tidss: Make use of the helper macro SET_RUNTIME_PM_OPS()")
Signed-off-by: Cai Huoqing <[email protected]>
---
drivers/gpu/drm/tidss/tidss_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/tidss/tidss_drv.c b/drivers/gpu/drm/tidss/tidss_drv.c
index 4366b5c798e0..7c784e90e40e 100644
--- a/drivers/gpu/drm/tidss/tidss_drv.c
+++ b/drivers/gpu/drm/tidss/tidss_drv.c
@@ -88,7 +88,7 @@ static int __maybe_unused tidss_resume(struct device *dev)
return drm_mode_config_helper_resume(&tidss->ddev);
}

-static const struct dev_pm_ops tidss_pm_ops = {
+static __maybe_unused const struct dev_pm_ops tidss_pm_ops = {
SET_SYSTEM_SLEEP_PM_OPS(tidss_suspend, tidss_resume)
SET_RUNTIME_PM_OPS(tidss_pm_runtime_suspend, tidss_pm_runtime_resume, NULL)
};
--
2.25.1

2021-11-29 12:26:57

by Tomi Valkeinen

Subject: Re: [PATCH] drm/tidss: Fix warning: unused variable 'tidss_pm_ops'

On 29/11/2021 08:33, Cai Huoqing wrote:
> Mark 'tidss_pm_ops' as __maybe_unused to avoid
> the warning: unused variable 'tidss_pm_ops'
>
> Fixes: 6e120594631f ("drm/tidss: Make use of the helper macro SET_RUNTIME_PM_OPS()")
> Signed-off-by: Cai Huoqing <[email protected]>
> ---
> drivers/gpu/drm/tidss/tidss_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tidss/tidss_drv.c b/drivers/gpu/drm/tidss/tidss_drv.c
> index 4366b5c798e0..7c784e90e40e 100644
> --- a/drivers/gpu/drm/tidss/tidss_drv.c
> +++ b/drivers/gpu/drm/tidss/tidss_drv.c
> @@ -88,7 +88,7 @@ static int __maybe_unused tidss_resume(struct device *dev)
> return drm_mode_config_helper_resume(&tidss->ddev);
> }
>
> -static const struct dev_pm_ops tidss_pm_ops = {
> +static __maybe_unused const struct dev_pm_ops tidss_pm_ops = {
> SET_SYSTEM_SLEEP_PM_OPS(tidss_suspend, tidss_resume)
> SET_RUNTIME_PM_OPS(tidss_pm_runtime_suspend, tidss_pm_runtime_resume, NULL)
> };

Thanks, I'll push to drm-misc-next.

Tomi