2024-02-09 13:06:22

by Dan Carpenter

Subject: [PATCH] dm vdo slab-depot: delete unnecessary check

This is a duplicate check so it can't be true. Delete it.

Signed-off-by: Dan Carpenter <[email protected]>
---
drivers/md/dm-vdo/slab-depot.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/md/dm-vdo/slab-depot.c b/drivers/md/dm-vdo/slab-depot.c
index 42126bd60242..2f4a2ae5e082 100644
--- a/drivers/md/dm-vdo/slab-depot.c
+++ b/drivers/md/dm-vdo/slab-depot.c
@@ -4100,9 +4100,6 @@ static int allocate_components(struct slab_depot *depot,
};
}

- if (result != VDO_SUCCESS)
- return result;
-
slab_count = vdo_compute_slab_count(depot->first_block, depot->last_block,
depot->slab_size_shift);
if (thread_config->physical_zone_count > slab_count) {
--
2.43.0

2024-02-11 18:30:38

by Markus Elfring

Subject: Re: dm vdo slab-depot: delete unnecessary check

> This is a duplicate check

Was this implementation detail detected with any known source code analysis tool?


> so it can't be true. …

I suggest to reconsider this information a bit more.
Would you usually expect the outcome “result == VDO_SUCCESS” from a call
of the function “uds_allocate”?

Regards,
Markus

2024-02-11 18:55:21

by Mike Snitzer

Subject: Re: dm vdo slab-depot: delete unnecessary check

On Fri, Feb 09 2024 at 8:06P -0500,
Dan Carpenter <[email protected]> wrote:

> This is a duplicate check so it can't be true. Delete it.
>
> Signed-off-by: Dan Carpenter <[email protected]>
> ---
> drivers/md/dm-vdo/slab-depot.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/md/dm-vdo/slab-depot.c b/drivers/md/dm-vdo/slab-depot.c
> index 42126bd60242..2f4a2ae5e082 100644
> --- a/drivers/md/dm-vdo/slab-depot.c
> +++ b/drivers/md/dm-vdo/slab-depot.c
> @@ -4100,9 +4100,6 @@ static int allocate_components(struct slab_depot *depot,
> };
> }
>
> - if (result != VDO_SUCCESS)
> - return result;
> -
> slab_count = vdo_compute_slab_count(depot->first_block, depot->last_block,
> depot->slab_size_shift);
> if (thread_config->physical_zone_count > slab_count) {
> --
> 2.43.0
>
>

Looks good, I've picked this up.

Thanks,
Mike