2022-03-03 16:16:43

by fuyao

[permalink] [raw]
Subject: [PATCH] sunxi:dts: remove r40 can node

it does not have can in r40/a40i/t3.so delete it.

Signed-off-by: fuyao <[email protected]>
---
arch/arm/boot/dts/sun8i-r40.dtsi | 9 ---------
1 file changed, 9 deletions(-)

diff --git a/arch/arm/boot/dts/sun8i-r40.dtsi b/arch/arm/boot/dts/sun8i-r40.dtsi
index 03d3e5f45a09..dde803b6ada0 100644
--- a/arch/arm/boot/dts/sun8i-r40.dtsi
+++ b/arch/arm/boot/dts/sun8i-r40.dtsi
@@ -936,15 +936,6 @@ i2c3: i2c@1c2b800 {
#size-cells = <0>;
};

- can0: can@1c2bc00 {
- compatible = "allwinner,sun8i-r40-can";
- reg = <0x01c2bc00 0x400>;
- interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&ccu CLK_BUS_CAN>;
- resets = <&ccu RST_BUS_CAN>;
- status = "disabled";
- };
-
i2c4: i2c@1c2c000 {
compatible = "allwinner,sun6i-a31-i2c";
reg = <0x01c2c000 0x400>;
--
2.32.0


--
Technology is exciting


2022-03-09 02:14:27

by Evgeny Boger

[permalink] [raw]
Subject: Re: [PATCH] sunxi:dts: remove r40 can node

Hi,

as I explained in the original commit message, CAN is definitely there
and is working perfectly at least on A40i.
I know it was removed from the user manual, but I personally verified
that it is working.

Maybe you can tell why CAN should be removed besides not being described
in the manual? Are there some hardware or maybe license issues?

Thanks!

--
 Best wishes,
 Evgeny Boger
 CTO @ wirenboard.com





2022-03-14 09:29:47

by fuyao

[permalink] [raw]
Subject: Re: [PATCH] sunxi:dts: remove r40 can node

On Wed, Mar 09, 2022 at 02:44:56AM +0300, Evgeny Boger wrote:
> Hi,
>
> as I explained in the original commit message, CAN is definitely there and
> is working perfectly at least on A40i.
> I know it was removed from the user manual, but I personally verified that
> it is working.
sorry, I forgot read the commit msg;
>
> Maybe you can tell why CAN should be removed besides not being described in
> the manual? Are there some hardware or maybe license issues?

i will test it again.

thanks!

>
> Thanks!
>
> --
> ?Best wishes,
> ?Evgeny Boger
> ?CTO @ wirenboard.com
>
>
>
>

--
Technology is exciting