2023-09-05 17:56:32

by Yinbo Zhu

[permalink] [raw]
Subject: [PATCH] soc: loongson2_pm: add dependency on INPUT

This fixes some undefined references to `input_set_capability' and
`input_register_device` issue when INPUT is not enabled.

Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/all/[email protected]/
Signed-off-by: Yinbo Zhu <[email protected]>
---
drivers/soc/loongson/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/soc/loongson/Kconfig b/drivers/soc/loongson/Kconfig
index 314e13bb3e01c..1b57af1e55298 100644
--- a/drivers/soc/loongson/Kconfig
+++ b/drivers/soc/loongson/Kconfig
@@ -20,6 +20,7 @@ config LOONGSON2_GUTS
config LOONGSON2_PM
bool "Loongson-2 SoC Power Management Controller Driver"
depends on LOONGARCH && OF
+ depends on INPUT
help
The Loongson-2's power management controller was ACPI, supports ACPI
S2Idle (Suspend To Idle), ACPI S3 (Suspend To RAM), ACPI S4 (Suspend To
--
2.31.1


2023-09-06 06:41:30

by Yinbo Zhu

[permalink] [raw]
Subject: Re: [PATCH] soc: loongson2_pm: add dependency on INPUT



在 2023/9/6 上午8:37, Randy Dunlap 写道:
> Hi--
>
> On 9/5/23 05:36, Yinbo Zhu wrote:
>> This fixes some undefined references to `input_set_capability' and
>> `input_register_device` issue when INPUT is not enabled.
>>
>> Reported-by: kernel test robot <[email protected]>
>> Closes: https://lore.kernel.org/all/[email protected]/
>> Signed-off-by: Yinbo Zhu <[email protected]>
>> ---
>> drivers/soc/loongson/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/soc/loongson/Kconfig b/drivers/soc/loongson/Kconfig
>> index 314e13bb3e01c..1b57af1e55298 100644
>> --- a/drivers/soc/loongson/Kconfig
>> +++ b/drivers/soc/loongson/Kconfig
>> @@ -20,6 +20,7 @@ config LOONGSON2_GUTS
>> config LOONGSON2_PM
>> bool "Loongson-2 SoC Power Management Controller Driver"
>> depends on LOONGARCH && OF
>> + depends on INPUT
>> help
>> The Loongson-2's power management controller was ACPI, supports ACPI
>> S2Idle (Suspend To Idle), ACPI S3 (Suspend To RAM), ACPI S4 (Suspend To
>
> The preferred patch has already been posted:
>


Sorry, I didn't notice it, and please ignore my patch, use zhoubinbin's
patch.

Thanks,
Yinbo

> https://lore.kernel.org/all/16a37f6ad3cc9417b6638c2cd532d88c79468eb1.1693623752.git.zhoubinbin@loongson.cn/
>