2023-11-30 12:07:25

by Wadim Egorov

Subject: Re: [Upstream] [PATCH 1/3] arm64: dts: ti: k3-am625-phyboard-lyra-rdk: Lower I2C1 frequency

Am 29.11.23 um 19:38 schrieb Garrett Giordano:
> The gpio-expander on i2c-1 has a maximum frequency of 100kHz. Update our
> main_i2c1 frequency to allow the nxp,pcf8574 gpio-expander to function
> properly.
>
> Signed-off-by: Garrett Giordano <[email protected]>

For all three patches,

Reviewed-by: Wadim Egorov <[email protected]>


> ---
> arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts b/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts
> index a438baf542c2..171354b13e33 100644
> --- a/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts
> @@ -187,7 +187,7 @@ cpsw3g_phy3: ethernet-phy@3 {
> &main_i2c1 {
> pinctrl-names = "default";
> pinctrl-0 = <&main_i2c1_pins_default>;
> - clock-frequency = <400000>;
> + clock-frequency = <100000>;
> status = "okay";
>
> gpio_exp: gpio-expander@21 {

2023-12-04 13:51:34

by Nishanth Menon

Subject: Re: [Upstream] [PATCH 1/3] arm64: dts: ti: k3-am625-phyboard-lyra-rdk: Lower I2C1 frequency

On 13:07-20231130, Wadim Egorov wrote:
>
> Am 29.11.23 um 19:38 schrieb Garrett Giordano:
> > The gpio-expander on i2c-1 has a maximum frequency of 100kHz. Update our
> > main_i2c1 frequency to allow the nxp,pcf8574 gpio-expander to function
> > properly.
> >
> > Signed-off-by: Garrett Giordano <[email protected]>
>
> For all three patches,
>
> Reviewed-by: Wadim Egorov <[email protected]>
>
>
> > ---
> > arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts b/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts
> > index a438baf542c2..171354b13e33 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts
> > +++ b/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts
> > @@ -187,7 +187,7 @@ cpsw3g_phy3: ethernet-phy@3 {
> > &main_i2c1 {
> > pinctrl-names = "default";
> > pinctrl-0 = <&main_i2c1_pins_default>;
> > - clock-frequency = <400000>;
> > + clock-frequency = <100000>;
> > status = "okay";
> > gpio_exp: gpio-expander@21 {


Please resubmit the patches - the archives don't seem to have a copy
and b4 drops out. Also, when doing that, please pick up the reviews.

--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D