2018-05-18 10:10:58

by Colin King

Subject: [PATCH] hippi: fix spelling mistake: "Framming" -> "Framing"

From: Colin Ian King <[email protected]>

Trivial fix to spelling mistake in printk message text

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/net/hippi/rrunner.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/hippi/rrunner.c b/drivers/net/hippi/rrunner.c
index 1ab97d99b9ba..f41116488079 100644
--- a/drivers/net/hippi/rrunner.c
+++ b/drivers/net/hippi/rrunner.c
@@ -867,7 +867,7 @@ static u32 rr_handle_event(struct net_device *dev, u32 prodidx, u32 eidx)
dev->name);
goto drop;
case E_FRM_ERR:
- printk(KERN_WARNING "%s: Framming Error\n",
+ printk(KERN_WARNING "%s: Framing Error\n",
dev->name);
goto drop;
case E_FLG_SYN_ERR:
--
2.17.0

2018-05-18 14:35:05

by Jes Sorensen

Subject: Re: [PATCH] hippi: fix spelling mistake: "Framming" -> "Framing"

On 05/18/2018 06:09 AM, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> Trivial fix to spelling mistake in printk message text
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/net/hippi/rrunner.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/hippi/rrunner.c b/drivers/net/hippi/rrunner.c
> index 1ab97d99b9ba..f41116488079 100644
> --- a/drivers/net/hippi/rrunner.c
> +++ b/drivers/net/hippi/rrunner.c
> @@ -867,7 +867,7 @@ static u32 rr_handle_event(struct net_device *dev, u32 prodidx, u32 eidx)
> dev->name);
> goto drop;
> case E_FRM_ERR:
> - printk(KERN_WARNING "%s: Framming Error\n",
> + printk(KERN_WARNING "%s: Framing Error\n",
> dev->name);
> goto drop;
> case E_FLG_SYN_ERR:
>

Fine with me! I do wonder if it's time to retire this driver and the
HIPPI code. I haven't had access to hardware for over a decade so I have
no idea if it even works anymore.

Jes

2018-05-18 15:28:18

by David Miller

Subject: Re: [PATCH] hippi: fix spelling mistake: "Framming" -> "Framing"

From: Jes Sorensen <[email protected]>
Date: Fri, 18 May 2018 10:33:50 -0400

> I do wonder if it's time to retire this driver and the HIPPI code. I
> haven't had access to hardware for over a decade so I have no idea
> if it even works anymore.

That's a good question.

If you really think nobody is using this stuff, yes we can remove it.

Then if someone brings it to our attention that there are users, we
can very easily bring it back.

But as the HIPPI maintiner it is really up to you.

2018-05-18 17:47:23

by David Miller

Subject: Re: [PATCH] hippi: fix spelling mistake: "Framming" -> "Framing"

From: Colin King <[email protected]>
Date: Fri, 18 May 2018 11:09:22 +0100

> From: Colin Ian King <[email protected]>
>
> Trivial fix to spelling mistake in printk message text
>
> Signed-off-by: Colin Ian King <[email protected]>

Applied.