On Tue, May 17, 2022 at 04:24:25PM +0000, Maximilian Heyne wrote:
> Since commit 4d65adfcd119 ("x86: xen: insn: Decode Xen and KVM
> emulate-prefix signature"), objtool is able to correctly parse the
> prefixed instruction in xen_cpuid and emit correct orc unwind
> information. Hence, marking the function as STACKFRAME_NON_STANDARD is
> no longer needed.
>
> This commit is basically a revert of commit 983bb6d254c7 ("x86/xen: Mark
> xen_cpuid() stack frame as non-standard").
>
> Signed-off-by: Maximilian Heyne <[email protected]>
> CC: Josh Poimboeuf <[email protected]>
>
> cr: https://code.amazon.com/reviews/CR-69645080
^^^^^
This looks like an internal amazon link and should be removed.
Otherwise, looks good to me.
Acked-by: Josh Poimboeuf <[email protected]>
--
Josh
On 17.05.22 18:42, Josh Poimboeuf wrote:
> On Tue, May 17, 2022 at 04:24:25PM +0000, Maximilian Heyne wrote:
>> Since commit 4d65adfcd119 ("x86: xen: insn: Decode Xen and KVM
>> emulate-prefix signature"), objtool is able to correctly parse the
>> prefixed instruction in xen_cpuid and emit correct orc unwind
>> information. Hence, marking the function as STACKFRAME_NON_STANDARD is
>> no longer needed.
>>
>> This commit is basically a revert of commit 983bb6d254c7 ("x86/xen: Mark
>> xen_cpuid() stack frame as non-standard").
>>
>> Signed-off-by: Maximilian Heyne <[email protected]>
>> CC: Josh Poimboeuf <[email protected]>
>>
>> cr: https://code.amazon.com/reviews/CR-69645080
> ^^^^^
>
> This looks like an internal amazon link and should be removed.
> Otherwise, looks good to me.
Can be done while committing.
Reviewed-by: Juergen Gross <[email protected]>
Juergen