2022-10-27 17:45:21

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 5.10 00/79] 5.10.151-rc1 review

This is the start of the stable review cycle for the 5.10.151 release.
There are 79 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.

Responses should be made by Sat, 29 Oct 2022 16:50:35 +0000.
Anything received after that time might be too late.

The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.151-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

Greg Kroah-Hartman <[email protected]>
Linux 5.10.151-rc1

Seth Jenkins <[email protected]>
mm: /proc/pid/smaps_rollup: fix no vma's null-deref

Yu Kuai <[email protected]>
blk-wbt: fix that 'rwb->wc' is always set to 1 in wbt_init()

Avri Altman <[email protected]>
mmc: core: Add SD card quirk for broken discard

Nick Desaulniers <[email protected]>
Makefile.debug: re-enable debug info for .S files

Nathan Chancellor <[email protected]>
x86/Kconfig: Drop check for -mabi=ms for CONFIG_EFI_STUB

Werner Sembach <[email protected]>
ACPI: video: Force backlight native for more TongFang devices

Gaurav Kohli <[email protected]>
hv_netvsc: Fix race between VF offering and VF association message from host

Adrian Hunter <[email protected]>
perf/x86/intel/pt: Relax address filter validation

Conor Dooley <[email protected]>
riscv: topology: fix default topology reporting

Conor Dooley <[email protected]>
arm64: topology: move store_cpu_topology() to shared code

Sibi Sankar <[email protected]>
arm64: dts: qcom: sc7180-trogdor: Fixup modem memory region

Desmond Cheong Zhi Xi <[email protected]>
fcntl: fix potential deadlocks for &fown_struct.lock

Pavel Tikhomirov <[email protected]>
fcntl: make F_GETOWN(EX) return 0 on dead owner task

Rob Herring <[email protected]>
perf: Skip and warn on unknown format 'configN' attrs

Jin Yao <[email protected]>
perf pmu: Validate raw event with sysfs exported format bits

Wenting Zhang <[email protected]>
riscv: always honor the CONFIG_CMDLINE_FORCE when parsing dtb

Kefeng Wang <[email protected]>
riscv: Add machine name to kernel boot log and stack dump output

Prathamesh Shete <[email protected]>
mmc: sdhci-tegra: Use actual clock rate for SW tuning correction

M. Vefa Bicakci <[email protected]>
xen/gntdev: Accommodate VMA splitting

Juergen Gross <[email protected]>
xen: assume XENFEAT_gnttab_map_avail_bits being set for pv guests

Steven Rostedt (Google) <[email protected]>
tracing: Do not free snapshot if tracer is on cmdline

sunliming <[email protected]>
tracing: Simplify conditional compilation code in tracing_set_tracer()

Dario Binacchi <[email protected]>
dmaengine: mxs: use platform_driver_register

Fabio Estevam <[email protected]>
dmaengine: mxs-dma: Remove the unused .id_table

Dmitry Osipenko <[email protected]>
drm/virtio: Use appropriate atomic state in virtio_gpu_plane_cleanup_fb()

Jerry Snitselaar <[email protected]>
iommu/vt-d: Clean up si_domain in the init_dmars() error path

Charlotte Tan <[email protected]>
iommu/vt-d: Allow NVS regions in arch_rmrr_sanity_check()

Felix Riemann <[email protected]>
net: phy: dp83822: disable MDI crossover status change interrupt

Eric Dumazet <[email protected]>
net: sched: fix race condition in qdisc_graft()

Yang Yingliang <[email protected]>
net: hns: fix possible memory leak in hnae_ae_register()

Pieter Jansen van Vuuren <[email protected]>
sfc: include vport_id in filter spec hash and equal()

Zhengchao Shao <[email protected]>
net: sched: sfb: fix null pointer access issue when sfb_init() fails

Zhengchao Shao <[email protected]>
net: sched: delete duplicate cleanup of backlog and qlen

Zhengchao Shao <[email protected]>
net: sched: cake: fix null pointer access issue when cake_init() fails

Serge Semin <[email protected]>
nvme-hwmon: kmalloc the NVME SMART log buffer

Christoph Hellwig <[email protected]>
nvme-hwmon: consistently ignore errors from nvme_hwmon_init

Daniel Wagner <[email protected]>
nvme-hwmon: Return error code when registration fails

Hannes Reinecke <[email protected]>
nvme-hwmon: rework to avoid devm allocation

Brett Creeley <[email protected]>
ionic: catch NULL pointer issue on reconfig

Eric Dumazet <[email protected]>
net: hsr: avoid possible NULL deref in skb_clone()

Zhang Xiaoxu <[email protected]>
cifs: Fix xid leak in cifs_ses_add_channel()

Zhang Xiaoxu <[email protected]>
cifs: Fix xid leak in cifs_flock()

Zhang Xiaoxu <[email protected]>
cifs: Fix xid leak in cifs_copy_file_range()

Kuniyuki Iwashima <[email protected]>
udp: Update reuse->has_conns under reuseport_lock.

Kuniyuki Iwashima <[email protected]>
tcp: Add num_closed_socks to struct sock_reuseport.

Harini Katakam <[email protected]>
net: phy: dp83867: Extend RX strap quirk for SGMII mode

Xiaobo Liu <[email protected]>
net/atm: fix proc_mpc_write incorrect return value

Jonathan Cooper <[email protected]>
sfc: Change VF mac via PF as first preference if available.

José Expósito <[email protected]>
HID: magicmouse: Do not set BTN_MOUSE on double report

Jan Sokolowski <[email protected]>
i40e: Fix DMA mappings leak

Alexander Potapenko <[email protected]>
tipc: fix an information leak in tipc_topsrv_kern_subscr

Mark Tomlinson <[email protected]>
tipc: Fix recognition of trial period

Tony Luck <[email protected]>
ACPI: extlog: Handle multiple records

Filipe Manana <[email protected]>
btrfs: fix processing of delayed tree block refs during backref walking

Filipe Manana <[email protected]>
btrfs: fix processing of delayed data refs during backref walking

Jean-Francois Le Fillatre <[email protected]>
r8152: add PID for the Lenovo OneLink+ Dock

James Morse <[email protected]>
arm64: errata: Remove AES hwcap for COMPAT tasks

Yu Kuai <[email protected]>
blk-wbt: call rq_qos_add() after wb_normal is initialized

Lei Chen <[email protected]>
block: wbt: Remove unnecessary invoking of wbt_update_limits in wbt_init

Martin Rodriguez Reboredo <[email protected]>
kbuild: Add skip_encoding_btf_enum64 option to pahole

Jiri Olsa <[email protected]>
kbuild: Unify options for BTF generation for vmlinux and modules

Andrii Nakryiko <[email protected]>
kbuild: skip per-CPU BTF generation for pahole v1.18-v1.21

Javier Martinez Canillas <[email protected]>
kbuild: Quote OBJCOPY var to avoid a pahole call break the build

Ilya Leoshkevich <[email protected]>
bpf: Generate BTF_KIND_FLOAT when linking vmlinux

Bryan O'Donoghue <[email protected]>
media: venus: dec: Handle the case where find_format fails

Sean Young <[email protected]>
media: mceusb: set timeout to at least timeout provided

Eric Ren <[email protected]>
KVM: arm64: vgic: Fix exit condition in scan_its_table()

Alexander Graf <[email protected]>
kvm: Add support for arch compat vm ioctls

Fabien Parent <[email protected]>
cpufreq: qcom: fix memory leak in error path

Kai-Heng Feng <[email protected]>
ata: ahci: Match EM_MAX_SLOTS with SATA_PMP_MAX_PORTS

Alexander Stein <[email protected]>
ata: ahci-imx: Fix MODULE_ALIAS

Zhang Rui <[email protected]>
hwmon/coretemp: Handle large core ID value

Borislav Petkov <[email protected]>
x86/microcode/AMD: Apply the patch early on every logical thread

Jon Hunter <[email protected]>
cpufreq: tegra194: Fix module loading

Bryan O'Donoghue <[email protected]>
i2c: qcom-cci: Fix ordering of pm_runtime_xx and i2c_add_adapter

Fabien Parent <[email protected]>
cpufreq: qcom: fix writes in read-only memory region

GONG, Ruiqi <[email protected]>
selinux: enable use of both GFP_KERNEL and GFP_ATOMIC in convert_context()

Joseph Qi <[email protected]>
ocfs2: fix BUG when iput after ocfs2_mknod fails

Joseph Qi <[email protected]>
ocfs2: clear dinode links count in case of error


-------------

Diffstat:

Documentation/arm64/silicon-errata.rst | 4 +
Makefile | 11 ++-
arch/arm64/Kconfig | 16 ++++
.../boot/dts/qcom/sc7180-trogdor-lte-sku.dtsi | 4 +
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 2 +-
arch/arm64/include/asm/cpucaps.h | 3 +-
arch/arm64/kernel/cpu_errata.c | 16 ++++
arch/arm64/kernel/cpufeature.c | 13 ++-
arch/arm64/kernel/topology.c | 40 ---------
arch/arm64/kvm/vgic/vgic-its.c | 5 +-
arch/riscv/Kconfig | 2 +-
arch/riscv/kernel/setup.c | 13 ++-
arch/riscv/kernel/smpboot.c | 4 +-
arch/x86/Kconfig | 1 -
arch/x86/events/intel/pt.c | 63 ++++++++++++---
arch/x86/include/asm/iommu.h | 4 +-
arch/x86/kernel/cpu/microcode/amd.c | 16 +++-
block/blk-wbt.c | 11 +--
drivers/acpi/acpi_extlog.c | 33 +++++---
drivers/acpi/video_detect.c | 64 +++++++++++++++
drivers/ata/ahci.h | 2 +-
drivers/ata/ahci_imx.c | 2 +-
drivers/base/arch_topology.c | 19 +++++
drivers/cpufreq/qcom-cpufreq-nvmem.c | 10 ++-
drivers/cpufreq/tegra194-cpufreq.c | 1 +
drivers/dma/mxs-dma.c | 48 +++--------
drivers/gpu/drm/virtio/virtgpu_plane.c | 6 +-
drivers/hid/hid-magicmouse.c | 2 +-
drivers/hwmon/coretemp.c | 56 +++++++++----
drivers/i2c/busses/i2c-qcom-cci.c | 13 +--
drivers/iommu/intel/iommu.c | 5 ++
drivers/media/platform/qcom/venus/vdec.c | 2 +
drivers/media/rc/mceusb.c | 2 +-
drivers/mmc/core/block.c | 7 +-
drivers/mmc/core/card.h | 6 ++
drivers/mmc/core/quirks.h | 6 ++
drivers/mmc/host/sdhci-tegra.c | 2 +-
drivers/net/ethernet/hisilicon/hns/hnae.c | 4 +-
drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 3 -
drivers/net/ethernet/intel/i40e/i40e_main.c | 16 ++--
drivers/net/ethernet/intel/i40e/i40e_txrx.c | 13 ++-
drivers/net/ethernet/intel/i40e/i40e_txrx.h | 1 -
drivers/net/ethernet/intel/i40e/i40e_xsk.c | 67 +++++++++++++--
drivers/net/ethernet/intel/i40e/i40e_xsk.h | 2 +-
drivers/net/ethernet/pensando/ionic/ionic_lif.c | 12 ++-
drivers/net/ethernet/sfc/ef10.c | 58 ++++++-------
drivers/net/ethernet/sfc/filter.h | 3 +-
drivers/net/ethernet/sfc/rx_common.c | 10 +--
drivers/net/hyperv/hyperv_net.h | 3 +-
drivers/net/hyperv/netvsc.c | 4 +
drivers/net/hyperv/netvsc_drv.c | 20 +++++
drivers/net/phy/dp83822.c | 3 +-
drivers/net/phy/dp83867.c | 8 ++
drivers/net/usb/cdc_ether.c | 7 ++
drivers/net/usb/r8152.c | 1 +
drivers/nvme/host/core.c | 7 +-
drivers/nvme/host/hwmon.c | 58 +++++++++----
drivers/nvme/host/nvme.h | 8 ++
drivers/xen/gntdev-common.h | 3 +-
drivers/xen/gntdev.c | 94 +++++++---------------
fs/btrfs/backref.c | 46 +++++++----
fs/cifs/cifsfs.c | 7 +-
fs/cifs/file.c | 11 ++-
fs/cifs/sess.c | 1 +
fs/fcntl.c | 32 +++++---
fs/ocfs2/namei.c | 23 +++---
fs/proc/task_mmu.c | 2 +-
include/linux/kvm_host.h | 2 +
include/linux/mmc/card.h | 1 +
include/net/sch_generic.h | 1 -
include/net/sock_reuseport.h | 16 ++--
kernel/trace/trace.c | 12 +--
net/atm/mpoa_proc.c | 3 +-
net/core/sock_reuseport.c | 91 ++++++++++++++++-----
net/hsr/hsr_forward.c | 12 +--
net/ipv4/datagram.c | 2 +-
net/ipv4/udp.c | 2 +-
net/ipv6/datagram.c | 2 +-
net/ipv6/udp.c | 2 +-
net/sched/sch_api.c | 5 +-
net/sched/sch_atm.c | 1 -
net/sched/sch_cake.c | 4 +
net/sched/sch_cbq.c | 1 -
net/sched/sch_choke.c | 2 -
net/sched/sch_drr.c | 2 -
net/sched/sch_dsmark.c | 2 -
net/sched/sch_etf.c | 3 -
net/sched/sch_ets.c | 2 -
net/sched/sch_fq_codel.c | 2 -
net/sched/sch_fq_pie.c | 3 -
net/sched/sch_hfsc.c | 2 -
net/sched/sch_htb.c | 2 -
net/sched/sch_multiq.c | 1 -
net/sched/sch_prio.c | 2 -
net/sched/sch_qfq.c | 2 -
net/sched/sch_red.c | 2 -
net/sched/sch_sfb.c | 5 +-
net/sched/sch_skbprio.c | 3 -
net/sched/sch_taprio.c | 2 -
net/sched/sch_tbf.c | 2 -
net/sched/sch_teql.c | 1 -
net/tipc/discover.c | 2 +-
net/tipc/topsrv.c | 2 +-
scripts/link-vmlinux.sh | 2 +-
scripts/pahole-flags.sh | 21 +++++
security/selinux/ss/services.c | 5 +-
security/selinux/ss/sidtab.c | 4 +-
security/selinux/ss/sidtab.h | 2 +-
tools/perf/util/parse-events.c | 6 ++
tools/perf/util/pmu.c | 50 ++++++++++++
tools/perf/util/pmu.h | 5 ++
tools/perf/util/pmu.l | 2 -
tools/perf/util/pmu.y | 15 +---
virt/kvm/kvm_main.c | 11 +++
114 files changed, 889 insertions(+), 476 deletions(-)




2022-10-27 19:03:07

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH 5.10 00/79] 5.10.151-rc1 review

On 10/27/22 09:55, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.151 release.
> There are 79 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sat, 29 Oct 2022 16:50:35 +0000.
> Anything received after that time might be too late.
>

Building arm64:allmodconfig ... failed
--------------
Error log:
/bin/sh: scripts/pahole-flags.sh: Permission denied

Indeed:

$ ls -l scripts/pahole-flags.sh
-rw-rw-r-- 1 groeck groeck 530 Oct 27 11:08 scripts/pahole-flags.sh

Compared to upstream:

-rwxrwxr-x 1 groeck groeck 585 Oct 20 11:31 scripts/pahole-flags.sh

Guenter


2022-10-27 20:05:25

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH 5.10 00/79] 5.10.151-rc1 review

On 10/27/22 12:39, Guenter Roeck wrote:
> On 10/27/22 12:27, Pavel Machek wrote:
>> On Thu 2022-10-27 21:25:54, Greg Kroah-Hartman wrote:
>>> On Thu, Oct 27, 2022 at 11:10:18AM -0700, Guenter Roeck wrote:
>>>> On 10/27/22 09:55, Greg Kroah-Hartman wrote:
>>>>> This is the start of the stable review cycle for the 5.10.151 release.
>>>>> There are 79 patches in this series, all will be posted as a response
>>>>> to this one.  If anyone has any issues with these being applied,
>>>>> please
>>>>> let me know.
>>>>>
>>>>> Responses should be made by Sat, 29 Oct 2022 16:50:35 +0000.
>>>>> Anything received after that time might be too late.
>>>>>
>>>>
>>>> Building arm64:allmodconfig ... failed
>>>> --------------
>>>> Error log:
>>>> /bin/sh: scripts/pahole-flags.sh: Permission denied
>>>>
>>>> Indeed:
>>>>
>>>> $ ls -l scripts/pahole-flags.sh
>>>> -rw-rw-r-- 1 groeck groeck 530 Oct 27 11:08 scripts/pahole-flags.sh
>>>>
>>>> Compared to upstream:
>>>>
>>>> -rwxrwxr-x 1 groeck groeck 585 Oct 20 11:31 scripts/pahole-flags.sh
>>>
>>> Yeah, this is going to be an odd one.  I have to do this by hand as
>>> quilt and git quilt-import doesn't like setting the mode bit.
>>>
>>> I wonder if I should just make a single-commit release with this file in
>>> it, set to the proper permission, to get past this hurdle.  I'll think
>>> about it in the morning...
>>
>> Alternatively you can modify the caller to do /bin/sh /scripts/... so
>> it does not need a +x bit...
>>
>
> That should be done in mainline, though.

This is the second time this is reported unfortunately, so while we
could change things in mainline to avoid being dependent upon the file
permissions stored in git, this really seems to be a workflow issue
involving quilt.

Any chance you can run a fixup while you apply a patch Greg?
--
Florian


2022-10-27 20:34:00

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH 5.10 00/79] 5.10.151-rc1 review

On 10/27/22 12:27, Pavel Machek wrote:
> On Thu 2022-10-27 21:25:54, Greg Kroah-Hartman wrote:
>> On Thu, Oct 27, 2022 at 11:10:18AM -0700, Guenter Roeck wrote:
>>> On 10/27/22 09:55, Greg Kroah-Hartman wrote:
>>>> This is the start of the stable review cycle for the 5.10.151 release.
>>>> There are 79 patches in this series, all will be posted as a response
>>>> to this one. If anyone has any issues with these being applied, please
>>>> let me know.
>>>>
>>>> Responses should be made by Sat, 29 Oct 2022 16:50:35 +0000.
>>>> Anything received after that time might be too late.
>>>>
>>>
>>> Building arm64:allmodconfig ... failed
>>> --------------
>>> Error log:
>>> /bin/sh: scripts/pahole-flags.sh: Permission denied
>>>
>>> Indeed:
>>>
>>> $ ls -l scripts/pahole-flags.sh
>>> -rw-rw-r-- 1 groeck groeck 530 Oct 27 11:08 scripts/pahole-flags.sh
>>>
>>> Compared to upstream:
>>>
>>> -rwxrwxr-x 1 groeck groeck 585 Oct 20 11:31 scripts/pahole-flags.sh
>>
>> Yeah, this is going to be an odd one. I have to do this by hand as
>> quilt and git quilt-import doesn't like setting the mode bit.
>>
>> I wonder if I should just make a single-commit release with this file in
>> it, set to the proper permission, to get past this hurdle. I'll think
>> about it in the morning...
>
> Alternatively you can modify the caller to do /bin/sh /scripts/... so
> it does not need a +x bit...
>

That should be done in mainline, though.

Guenter



2022-10-27 20:38:52

by Pavel Machek

[permalink] [raw]
Subject: Re: [PATCH 5.10 00/79] 5.10.151-rc1 review

On Thu 2022-10-27 21:25:54, Greg Kroah-Hartman wrote:
> On Thu, Oct 27, 2022 at 11:10:18AM -0700, Guenter Roeck wrote:
> > On 10/27/22 09:55, Greg Kroah-Hartman wrote:
> > > This is the start of the stable review cycle for the 5.10.151 release.
> > > There are 79 patches in this series, all will be posted as a response
> > > to this one. If anyone has any issues with these being applied, please
> > > let me know.
> > >
> > > Responses should be made by Sat, 29 Oct 2022 16:50:35 +0000.
> > > Anything received after that time might be too late.
> > >
> >
> > Building arm64:allmodconfig ... failed
> > --------------
> > Error log:
> > /bin/sh: scripts/pahole-flags.sh: Permission denied
> >
> > Indeed:
> >
> > $ ls -l scripts/pahole-flags.sh
> > -rw-rw-r-- 1 groeck groeck 530 Oct 27 11:08 scripts/pahole-flags.sh
> >
> > Compared to upstream:
> >
> > -rwxrwxr-x 1 groeck groeck 585 Oct 20 11:31 scripts/pahole-flags.sh
>
> Yeah, this is going to be an odd one. I have to do this by hand as
> quilt and git quilt-import doesn't like setting the mode bit.
>
> I wonder if I should just make a single-commit release with this file in
> it, set to the proper permission, to get past this hurdle. I'll think
> about it in the morning...

Alternatively you can modify the caller to do /bin/sh /scripts/... so
it does not need a +x bit...

Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


Attachments:
(No filename) (1.53 kB)
signature.asc (201.00 B)
Download all attachments

2022-10-27 20:40:31

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 5.10 00/79] 5.10.151-rc1 review

On Thu, Oct 27, 2022 at 11:10:18AM -0700, Guenter Roeck wrote:
> On 10/27/22 09:55, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 5.10.151 release.
> > There are 79 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Sat, 29 Oct 2022 16:50:35 +0000.
> > Anything received after that time might be too late.
> >
>
> Building arm64:allmodconfig ... failed
> --------------
> Error log:
> /bin/sh: scripts/pahole-flags.sh: Permission denied
>
> Indeed:
>
> $ ls -l scripts/pahole-flags.sh
> -rw-rw-r-- 1 groeck groeck 530 Oct 27 11:08 scripts/pahole-flags.sh
>
> Compared to upstream:
>
> -rwxrwxr-x 1 groeck groeck 585 Oct 20 11:31 scripts/pahole-flags.sh

Yeah, this is going to be an odd one. I have to do this by hand as
quilt and git quilt-import doesn't like setting the mode bit.

I wonder if I should just make a single-commit release with this file in
it, set to the proper permission, to get past this hurdle. I'll think
about it in the morning...

thanks,

greg k-h

2022-10-27 20:42:59

by Linus Torvalds

[permalink] [raw]
Subject: Re: [PATCH 5.10 00/79] 5.10.151-rc1 review

On Thu, Oct 27, 2022 at 12:27 PM Pavel Machek <[email protected]> wrote:
>
> Alternatively you can modify the caller to do /bin/sh /scripts/... so
> it does not need a +x bit...

Generally we should be doing both.

Make it have the proper +x bit to show clearly that it's an executable
script and have 'ls' and friends show it that way when people enable
colorization or whatever.

*And* make any Makefiles and tooling use an explicit "sh" or whatever
thing, because we've traditionally let people use tar-files and patch
to generate their trees, and various stupid tools exist and get it
wrong even when we get it right in our git tree.

So belt and suspenders.

But in this case, I think our tools already do the "run shell" part:

Makefile:PAHOLE_FLAGS = $(shell PAHOLE=$(PAHOLE)
$(srctree)/scripts/pahole-flags.sh)

no? And at least in my -git tree, it's already executable.

Maybe one of those "various stipid tools exists" is in the stable
tree. I didn't check.

Linus

2022-10-28 11:31:09

by Sudip Mukherjee

[permalink] [raw]
Subject: Re: [PATCH 5.10 00/79] 5.10.151-rc1 review

Hi Greg,

On Thu, Oct 27, 2022 at 06:55:10PM +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.151 release.
> There are 79 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sat, 29 Oct 2022 16:50:35 +0000.
> Anything received after that time might be too late.

Build test (gcc version 11.3.1 20221016):
mips: 63 configs -> no failure
arm: 104 configs -> no failure
arm64: 3 configs -> 1 failure
x86_64: 4 configs -> no failure
alpha allmodconfig -> no failure
powerpc allmodconfig -> no failure
riscv allmodconfig -> no failure
s390 allmodconfig -> no failure
xtensa allmodconfig -> no failure

Note:
1) arm64 allmodconfig fails to build with the error:
In file included from drivers/cpufreq/tegra194-cpufreq.c:10:
drivers/cpufreq/tegra194-cpufreq.c:245:25: error: 'tegra194_cpufreq_of_match' undeclared here (not in a function); did you mean 'tegra194_cpufreq_data'?
245 | MODULE_DEVICE_TABLE(of, tegra194_cpufreq_of_match);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
./include/linux/module.h:241:15: note: in definition of macro 'MODULE_DEVICE_TABLE'
241 | extern typeof(name) __mod_##type##__##name##_device_table \
| ^~~~
./include/linux/module.h:241:21: error: conflicting types for '__mod_of__tegra194_cpufreq_of_match_device_table'; have 'const struct of_device_id[2]'
241 | extern typeof(name) __mod_##type##__##name##_device_table \
| ^~~~~~
drivers/cpufreq/tegra194-cpufreq.c:380:1: note: in expansion of macro 'MODULE_DEVICE_TABLE'
380 | MODULE_DEVICE_TABLE(of, tegra194_cpufreq_of_match);
| ^~~~~~~~~~~~~~~~~~~
./include/linux/module.h:241:21: note: previous declaration of '__mod_of__tegra194_cpufreq_of_match_device_table' with type 'int'
241 | extern typeof(name) __mod_##type##__##name##_device_table \
| ^~~~~~
drivers/cpufreq/tegra194-cpufreq.c:245:1: note: in expansion of macro 'MODULE_DEVICE_TABLE'
245 | MODULE_DEVICE_TABLE(of, tegra194_cpufreq_of_match);
| ^~~~~~~~~~~~~~~~~~~

git bisect pointed to a327a52c9930 ("cpufreq: tegra194: Fix module loading")

2) Already reported by others:
scripts/pahole-flags.sh: Permission denied


Boot test:
x86_64: Booted on my test laptop. No regression.
x86_64: Booted on qemu. No regression. [1]
arm64: Booted on rpi4b (4GB model). No regression. [2]

[1]. https://openqa.qa.codethink.co.uk/tests/2047
[2]. https://openqa.qa.codethink.co.uk/tests/2053


Tested-by: Sudip Mukherjee <[email protected]>

--
Regards
Sudip

2022-10-28 11:37:40

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 5.10 00/79] 5.10.151-rc1 review

On Thu, Oct 27, 2022 at 12:49:22PM -0700, Linus Torvalds wrote:
> On Thu, Oct 27, 2022 at 12:27 PM Pavel Machek <[email protected]> wrote:
> >
> > Alternatively you can modify the caller to do /bin/sh /scripts/... so
> > it does not need a +x bit...
>
> Generally we should be doing both.
>
> Make it have the proper +x bit to show clearly that it's an executable
> script and have 'ls' and friends show it that way when people enable
> colorization or whatever.
>
> *And* make any Makefiles and tooling use an explicit "sh" or whatever
> thing, because we've traditionally let people use tar-files and patch
> to generate their trees, and various stupid tools exist and get it
> wrong even when we get it right in our git tree.
>
> So belt and suspenders.
>
> But in this case, I think our tools already do the "run shell" part:
>
> Makefile:PAHOLE_FLAGS = $(shell PAHOLE=$(PAHOLE)
> $(srctree)/scripts/pahole-flags.sh)
>
> no? And at least in my -git tree, it's already executable.

In your tree, yes.

And when I export the patch, we get the proper:
create mode 100755 scripts/pahole-flags.sh
line added to the patch.

But then when importing the patch using:
git quilt-import
that line is totally ignored and the permissions are set to normal.

It's a long-running issue, and I think I'm about the only one that uses
git quilt-import outside of the debian build system, so it's low on my
list of things to fix up with that shell script (speed is my biggest
issue, it's just slow on large amounts of patches and needs to be
rewritten in C).

I'll go fix this up by hand...

thanks,

greg k-h

2022-10-28 12:04:31

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 5.10 00/79] 5.10.151-rc1 review

On Fri, Oct 28, 2022 at 11:47:27AM +0100, Sudip Mukherjee (Codethink) wrote:
> Hi Greg,
>
> On Thu, Oct 27, 2022 at 06:55:10PM +0200, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 5.10.151 release.
> > There are 79 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Sat, 29 Oct 2022 16:50:35 +0000.
> > Anything received after that time might be too late.
>
> Build test (gcc version 11.3.1 20221016):
> mips: 63 configs -> no failure
> arm: 104 configs -> no failure
> arm64: 3 configs -> 1 failure
> x86_64: 4 configs -> no failure
> alpha allmodconfig -> no failure
> powerpc allmodconfig -> no failure
> riscv allmodconfig -> no failure
> s390 allmodconfig -> no failure
> xtensa allmodconfig -> no failure
>
> Note:
> 1) arm64 allmodconfig fails to build with the error:
> In file included from drivers/cpufreq/tegra194-cpufreq.c:10:
> drivers/cpufreq/tegra194-cpufreq.c:245:25: error: 'tegra194_cpufreq_of_match' undeclared here (not in a function); did you mean 'tegra194_cpufreq_data'?
> 245 | MODULE_DEVICE_TABLE(of, tegra194_cpufreq_of_match);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> ./include/linux/module.h:241:15: note: in definition of macro 'MODULE_DEVICE_TABLE'
> 241 | extern typeof(name) __mod_##type##__##name##_device_table \
> | ^~~~
> ./include/linux/module.h:241:21: error: conflicting types for '__mod_of__tegra194_cpufreq_of_match_device_table'; have 'const struct of_device_id[2]'
> 241 | extern typeof(name) __mod_##type##__##name##_device_table \
> | ^~~~~~
> drivers/cpufreq/tegra194-cpufreq.c:380:1: note: in expansion of macro 'MODULE_DEVICE_TABLE'
> 380 | MODULE_DEVICE_TABLE(of, tegra194_cpufreq_of_match);
> | ^~~~~~~~~~~~~~~~~~~
> ./include/linux/module.h:241:21: note: previous declaration of '__mod_of__tegra194_cpufreq_of_match_device_table' with type 'int'
> 241 | extern typeof(name) __mod_##type##__##name##_device_table \
> | ^~~~~~
> drivers/cpufreq/tegra194-cpufreq.c:245:1: note: in expansion of macro 'MODULE_DEVICE_TABLE'
> 245 | MODULE_DEVICE_TABLE(of, tegra194_cpufreq_of_match);
> | ^~~~~~~~~~~~~~~~~~~
>
> git bisect pointed to a327a52c9930 ("cpufreq: tegra194: Fix module loading")

Now dropped.

> 2) Already reported by others:
> scripts/pahole-flags.sh: Permission denied

Will be fixed up by hand.

I'll be doing a new 5.10.y release in a few minutes and start a new
round of -rc review for it to resolve this...

thanks,

greg k-h

2022-10-28 12:06:59

by Jon Hunter

[permalink] [raw]
Subject: Re: [PATCH 5.10 00/79] 5.10.151-rc1 review

On Thu, 27 Oct 2022 18:55:10 +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.151 release.
> There are 79 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sat, 29 Oct 2022 16:50:35 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.151-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

All tests passing for Tegra ...

Test results for stable-v5.10:
11 builds: 11 pass, 0 fail
28 boots: 28 pass, 0 fail
75 tests: 75 pass, 0 fail

Linux version: 5.10.151-rc1-gaa25703d0a7c
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,
tegra194-p2972-0000, tegra194-p3509-0000+p3668-0000,
tegra20-ventana, tegra210-p2371-2180,
tegra210-p3450-0000, tegra30-cardhu-a04

Tested-by: Jon Hunter <[email protected]>

Jon

2022-10-28 13:32:51

by Pavel Machek

[permalink] [raw]
Subject: Re: [PATCH 5.10 00/79] 5.10.151-rc1 review

Hi!

> This is the start of the stable review cycle for the 5.10.151 release.
> There are 79 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.

CIP testing did not find any problems here:

https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-5.10.y

Tested-by: Pavel Machek (CIP) <[email protected]>

Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


Attachments:
(No filename) (661.00 B)
signature.asc (201.00 B)
Download all attachments

2022-10-28 14:40:38

by Naresh Kamboju

[permalink] [raw]
Subject: Re: [PATCH 5.10 00/79] 5.10.151-rc1 review

On Thu, 27 Oct 2022 at 22:35, Greg Kroah-Hartman
<[email protected]> wrote:
>
> This is the start of the stable review cycle for the 5.10.151 release.
> There are 79 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sat, 29 Oct 2022 16:50:35 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.151-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

Results from Linaro's test farm.
No regressions on arm64, arm, x86_64, and i386.

Tested-by: Linux Kernel Functional Testing <[email protected]>

## Build
* kernel: 5.10.151-rc1
* git: https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc
* git branch: linux-5.10.y
* git commit: aa25703d0a7c8d3158e3753b710a730892d32a13
* git describe: v5.10.150-80-gaa25703d0a7c
* test details:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.10.y/build/v5.10.150-80-gaa25703d0a7c

## No Test Regressions (compared to v5.10.149-391-gb4f4370de958)

## No Metric Regressions (compared to v5.10.149-391-gb4f4370de958)

## No Test Fixes (compared to v5.10.149-391-gb4f4370de958)

## No Metric Fixes (compared to v5.10.149-391-gb4f4370de958)


## Test result summary
total: 132473, pass: 112534, fail: 2525, skip: 17013, xfail: 401

## Build Summary
* arc: 5 total, 5 passed, 0 failed
* arm: 143 total, 142 passed, 1 failed
* arm64: 43 total, 41 passed, 2 failed
* i386: 35 total, 33 passed, 2 failed
* mips: 23 total, 23 passed, 0 failed
* parisc: 5 total, 5 passed, 0 failed
* powerpc: 25 total, 21 passed, 4 failed
* riscv: 10 total, 10 passed, 0 failed
* s390: 10 total, 10 passed, 0 failed
* sh: 10 total, 10 passed, 0 failed
* sparc: 6 total, 6 passed, 0 failed
* x86_64: 36 total, 34 passed, 2 failed

## Test suites summary
* fwts
* igt-gpu-tools
* kselftest-android
* kselftest-arm64
* kselftest-arm64/arm64.btitest.bti_c_func
* kselftest-arm64/arm64.btitest.bti_j_func
* kselftest-arm64/arm64.btitest.bti_jc_func
* kselftest-arm64/arm64.btitest.bti_none_func
* kselftest-arm64/arm64.btitest.nohint_func
* kselftest-arm64/arm64.btitest.paciasp_func
* kselftest-arm64/arm64.nobtitest.bti_c_func
* kselftest-arm64/arm64.nobtitest.bti_j_func
* kselftest-arm64/arm64.nobtitest.bti_jc_func
* kselftest-arm64/arm64.nobtitest.bti_none_func
* kselftest-arm64/arm64.nobtitest.nohint_func
* kselftest-arm64/arm64.nobtitest.paciasp_func
* kselftest-breakpoints
* kselftest-capabilities
* kselftest-drivers-dma-buf
* kselftest-efivarfs
* kselftest-filesystems
* kselftest-filesystems-binderfs
* kselftest-firmware
* kselftest-fpu
* kselftest-futex
* kselftest-gpio
* kselftest-intel_pstate
* kselftest-ipc
* kselftest-ir
* kselftest-kcmp
* kselftest-kexec
* kselftest-kvm
* kselftest-lib
* kselftest-livepatch
* kselftest-membarrier
* kselftest-memfd
* kselftest-memory-hotplug
* kselftest-mincore
* kselftest-mount
* kselftest-mqueue
* kselftest-net
* kselftest-net-forwarding
* kselftest-net-mptcp
* kselftest-netfilter
* kselftest-nsfs
* kselftest-openat2
* kselftest-pid_namespace
* kselftest-pidfd
* kselftest-proc
* kselftest-pstore
* kselftest-ptrace
* kselftest-rseq
* kselftest-rtc
* kselftest-tc-testing
* kselftest-timens
* kselftest-timers
* kselftest-tmpfs
* kselftest-tpm2
* kselftest-user
* kselftest-vm
* kselftest-x86
* kselftest-zram
* kunit
* kvm-unit-tests
* libgpiod
* libhugetlbfs
* log-parser-boot
* log-parser-test
* ltp-cap_bounds
* ltp-commands
* ltp-containers
* ltp-controllers
* ltp-cpuhotplug
* ltp-crypto
* ltp-cve
* ltp-dio
* ltp-fcntl-locktests
* ltp-filecaps
* ltp-fs
* ltp-fs_bind
* ltp-fs_perms_simple
* ltp-fsx
* ltp-hugetlb
* ltp-io
* ltp-ipc
* ltp-math
* ltp-mm
* ltp-nptl
* ltp-open-posix-tests
* ltp-pty
* ltp-sched
* ltp-securebits
* ltp-smoke
* ltp-syscalls
* ltp-tracing
* network-basic-tests
* packetdrill
* perf
* perf/Zstd-perf.data-compression
* rcutorture
* v4l2-compliance
* vdso

--
Linaro LKFT
https://lkft.linaro.org