2020-09-27 19:57:25

by Julia Lawall

Subject: [PATCH 15/18] counter: use semicolons rather than commas to separate statements

Replace commas with semicolons. What is done is essentially described by
the following Coccinelle semantic patch (http://coccinelle.lip6.fr/):

// <smpl>
@@ expression e1,e2; @@
e1
-,
+;
e2
... when any
// </smpl>

Signed-off-by: Julia Lawall <[email protected]>

---
drivers/counter/ti-eqep.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/counter/ti-eqep.c b/drivers/counter/ti-eqep.c
index 1ff07faef27f..e27771df8e23 100644
--- a/drivers/counter/ti-eqep.c
+++ b/drivers/counter/ti-eqep.c
@@ -439,7 +439,7 @@ static int ti_eqep_remove(struct platform_device *pdev)
struct device *dev = &pdev->dev;

counter_unregister(&priv->counter);
- pm_runtime_put_sync(dev),
+ pm_runtime_put_sync(dev);
pm_runtime_disable(dev);

return 0;

2020-09-28 15:57:43

by David Lechner

Subject: Re: [PATCH 15/18] counter: use semicolons rather than commas to separate statements

On 9/27/20 2:12 PM, Julia Lawall wrote:
> Replace commas with semicolons. What is done is essentially described by
> the following Coccinelle semantic patch (http://coccinelle.lip6.fr/):
>
> // <smpl>
> @@ expression e1,e2; @@
> e1
> -,
> +;
> e2
> ... when any
> // </smpl>
>
> Signed-off-by: Julia Lawall <[email protected]>
>
> ---
Reviewed-by: David Lechner <[email protected]>

2020-09-29 15:29:25

by Jonathan Cameron

Subject: Re: [PATCH 15/18] counter: use semicolons rather than commas to separate statements

On Mon, 28 Sep 2020 10:37:28 -0500
David Lechner <[email protected]> wrote:

> On 9/27/20 2:12 PM, Julia Lawall wrote:
> > Replace commas with semicolons. What is done is essentially described by
> > the following Coccinelle semantic patch (http://coccinelle.lip6.fr/):
> >
> > // <smpl>
> > @@ expression e1,e2; @@
> > e1
> > -,
> > +;
> > e2
> > ... when any
> > // </smpl>
> >
> > Signed-off-by: Julia Lawall <[email protected]>
> >
> > ---
> Reviewed-by: David Lechner <[email protected]>
I've picked this one up. Applied to the togreg branch of iio.git and
pushed out as testing for all the normal reasons.

Thanks,

Jonathan

>