2019-01-21 07:49:27

by Yue Haibing

Subject: [PATCH -next] staging: rtl8712: drop pointless static qualifier in r8712_efuse_pg_packet_write()

There is no need to have the 'intrepeat_times' variable static since new
value always be assigned before use it.

Signed-off-by: YueHaibing <[email protected]>
---
drivers/staging/rtl8712/rtl8712_efuse.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8712/rtl8712_efuse.c b/drivers/staging/rtl8712/rtl8712_efuse.c
index 8bc45ff..39eb743 100644
--- a/drivers/staging/rtl8712/rtl8712_efuse.c
+++ b/drivers/staging/rtl8712/rtl8712_efuse.c
@@ -358,7 +358,7 @@ u8 r8712_efuse_pg_packet_write(struct _adapter *padapter, const u8 offset,
u8 pg_header = 0;
u16 efuse_addr = 0, curr_size = 0;
u8 efuse_data, target_word_cnts = 0;
- static int repeat_times;
+ int repeat_times;
int sub_repeat;
u8 bResult = true;

2019-01-21 17:58:22

by Larry Finger

Subject: Re: [PATCH -next] staging: rtl8712: drop pointless static qualifier in r8712_efuse_pg_packet_write()

On 1/21/19 1:53 AM, YueHaibing wrote:
> There is no need to have the 'intrepeat_times' variable static since new
> value always be assigned before use it.
>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> drivers/staging/rtl8712/rtl8712_efuse.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8712/rtl8712_efuse.c b/drivers/staging/rtl8712/rtl8712_efuse.c
> index 8bc45ff..39eb743 100644
> --- a/drivers/staging/rtl8712/rtl8712_efuse.c
> +++ b/drivers/staging/rtl8712/rtl8712_efuse.c
> @@ -358,7 +358,7 @@ u8 r8712_efuse_pg_packet_write(struct _adapter *padapter, const u8 offset,
> u8 pg_header = 0;
> u16 efuse_addr = 0, curr_size = 0;
> u8 efuse_data, target_word_cnts = 0;
> - static int repeat_times;
> + int repeat_times;
> int sub_repeat;
> u8 bResult = true;

Clearly, the value of this variable is not intended to be carried over between
calls to this routine. Your fix is correct.

Acked-by: Larry Finger <[email protected]>

Thanks,

Larry