2023-10-23 11:27:01

by Geert Uytterhoeven

[permalink] [raw]
Subject: [PATCH] dt-bindings: regulator: dlg,da9210: Convert to json-schema

Convert the Dialog Semiconductor DA9210 Multi-Phase 12A DC-DC Buck
Converter Device Tree binding documentation to json-schema.

Signed-off-by: Geert Uytterhoeven <[email protected]>
---
.../devicetree/bindings/regulator/da9210.txt | 29 -----------
.../bindings/regulator/dlg,da9210.yaml | 52 +++++++++++++++++++
2 files changed, 52 insertions(+), 29 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/regulator/da9210.txt
create mode 100644 Documentation/devicetree/bindings/regulator/dlg,da9210.yaml

diff --git a/Documentation/devicetree/bindings/regulator/da9210.txt b/Documentation/devicetree/bindings/regulator/da9210.txt
deleted file mode 100644
index 58065ca9e3b46892..0000000000000000
--- a/Documentation/devicetree/bindings/regulator/da9210.txt
+++ /dev/null
@@ -1,29 +0,0 @@
-* Dialog Semiconductor DA9210 Multi-phase 12A DCDC BUCK Converter
-
-Required properties:
-
-- compatible: must be "dlg,da9210"
-- reg: the i2c slave address of the regulator. It should be 0x68.
-
-Optional properties:
-
-- interrupts: a reference to the DA9210 interrupt, if available.
-
-Any standard regulator properties can be used to configure the single da9210
-DCDC.
-
-Example:
-
- da9210@68 {
- compatible = "dlg,da9210";
- reg = <0x68>;
-
- interrupt-parent = <...>;
- interrupts = <...>;
-
- regulator-min-microvolt = <300000>;
- regulator-max-microvolt = <1570000>;
- regulator-min-microamp = <1600000>;
- regulator-max-microamp = <4600000>;
- regulator-boot-on;
- };
diff --git a/Documentation/devicetree/bindings/regulator/dlg,da9210.yaml b/Documentation/devicetree/bindings/regulator/dlg,da9210.yaml
new file mode 100644
index 0000000000000000..81f23de36de4c2f1
--- /dev/null
+++ b/Documentation/devicetree/bindings/regulator/dlg,da9210.yaml
@@ -0,0 +1,52 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/regulator/dlg,da9210.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Dialog Semiconductor DA9210 Multi-Phase 12A DC-DC Buck Converter
+
+maintainers:
+ - Support Opensource <[email protected]>
+
+allOf:
+ - $ref: regulator.yaml#
+
+properties:
+ compatible:
+ const: dlg,da9210
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ regulator@68 {
+ compatible = "dlg,da9210";
+ reg = <0x68>;
+
+ interrupt-parent = <&irqc0>;
+ interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
+
+ regulator-min-microvolt = <300000>;
+ regulator-max-microvolt = <1570000>;
+ regulator-min-microamp = <1600000>;
+ regulator-max-microamp = <4600000>;
+ regulator-boot-on;
+ };
+ };
--
2.34.1


2023-10-23 16:19:50

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: regulator: dlg,da9210: Convert to json-schema

On Mon, Oct 23, 2023 at 11:04:45AM +0200, Geert Uytterhoeven wrote:
> Convert the Dialog Semiconductor DA9210 Multi-Phase 12A DC-DC Buck
> Converter Device Tree binding documentation to json-schema.
>
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---
> .../devicetree/bindings/regulator/da9210.txt | 29 -----------
> .../bindings/regulator/dlg,da9210.yaml | 52 +++++++++++++++++++
> 2 files changed, 52 insertions(+), 29 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/regulator/da9210.txt
> create mode 100644 Documentation/devicetree/bindings/regulator/dlg,da9210.yaml
>
> diff --git a/Documentation/devicetree/bindings/regulator/da9210.txt b/Documentation/devicetree/bindings/regulator/da9210.txt
> deleted file mode 100644
> index 58065ca9e3b46892..0000000000000000
> --- a/Documentation/devicetree/bindings/regulator/da9210.txt
> +++ /dev/null
> @@ -1,29 +0,0 @@
> -* Dialog Semiconductor DA9210 Multi-phase 12A DCDC BUCK Converter
> -
> -Required properties:
> -
> -- compatible: must be "dlg,da9210"
> -- reg: the i2c slave address of the regulator. It should be 0x68.
> -
> -Optional properties:
> -
> -- interrupts: a reference to the DA9210 interrupt, if available.
> -
> -Any standard regulator properties can be used to configure the single da9210
> -DCDC.
> -
> -Example:
> -
> - da9210@68 {
> - compatible = "dlg,da9210";
> - reg = <0x68>;
> -
> - interrupt-parent = <...>;
> - interrupts = <...>;
> -
> - regulator-min-microvolt = <300000>;
> - regulator-max-microvolt = <1570000>;
> - regulator-min-microamp = <1600000>;
> - regulator-max-microamp = <4600000>;
> - regulator-boot-on;
> - };
> diff --git a/Documentation/devicetree/bindings/regulator/dlg,da9210.yaml b/Documentation/devicetree/bindings/regulator/dlg,da9210.yaml
> new file mode 100644
> index 0000000000000000..81f23de36de4c2f1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/dlg,da9210.yaml
> @@ -0,0 +1,52 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/dlg,da9210.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Dialog Semiconductor DA9210 Multi-Phase 12A DC-DC Buck Converter
> +
> +maintainers:
> + - Support Opensource <[email protected]>

This should really be a person... Does your work with Renesas cover you
for dialog stuff too?

Otherwise,
Reviewed-by: Conor Dooley <[email protected]>

Thanks,
Conor.

> +
> +allOf:
> + - $ref: regulator.yaml#
> +
> +properties:
> + compatible:
> + const: dlg,da9210
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + regulator@68 {
> + compatible = "dlg,da9210";
> + reg = <0x68>;
> +
> + interrupt-parent = <&irqc0>;
> + interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
> +
> + regulator-min-microvolt = <300000>;
> + regulator-max-microvolt = <1570000>;
> + regulator-min-microamp = <1600000>;
> + regulator-max-microamp = <4600000>;
> + regulator-boot-on;
> + };
> + };
> --
> 2.34.1
>


Attachments:
(No filename) (3.46 kB)
signature.asc (235.00 B)
Download all attachments

2023-10-23 17:59:20

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: regulator: dlg,da9210: Convert to json-schema

Hi Conor,

CC David, Adam

On Mon, Oct 23, 2023 at 6:18 PM Conor Dooley <[email protected]> wrote:
> On Mon, Oct 23, 2023 at 11:04:45AM +0200, Geert Uytterhoeven wrote:
> > Convert the Dialog Semiconductor DA9210 Multi-Phase 12A DC-DC Buck
> > Converter Device Tree binding documentation to json-schema.
> >
> > Signed-off-by: Geert Uytterhoeven <[email protected]>

> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/regulator/dlg,da9210.yaml
> > @@ -0,0 +1,52 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/regulator/dlg,da9210.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Dialog Semiconductor DA9210 Multi-Phase 12A DC-DC Buck Converter
> > +
> > +maintainers:
> > + - Support Opensource <[email protected]>
>
> This should really be a person... Does your work with Renesas cover you
> for dialog stuff too?

I'm not really into the PMICs department, only into making dtbs_check
for "my" DTS files clean ;-)
I hope one of the Dialog/Renesas PMIC people can point me to a better
address. Steve Twiss sent a goodbye message to some kernel people
and lkml three years ago, but it is not on lore, as it contained HTML.

Ah, according to git log, David and Adam touched some of the files
lately, so perhaps they can help?

> Otherwise,
> Reviewed-by: Conor Dooley <[email protected]>

Thanks!

Gr{oetje,eeting}s,

Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2023-10-24 16:34:13

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: regulator: dlg,da9210: Convert to json-schema

On Mon, Oct 23, 2023 at 07:58:51PM +0200, Geert Uytterhoeven wrote:
> CC David, Adam
>
> On Mon, Oct 23, 2023 at 6:18 PM Conor Dooley <[email protected]> wrote:
> > On Mon, Oct 23, 2023 at 11:04:45AM +0200, Geert Uytterhoeven wrote:

> > > +maintainers:
> > > + - Support Opensource <[email protected]>
> >
> > This should really be a person... Does your work with Renesas cover you
> > for dialog stuff too?
>
> I'm not really into the PMICs department, only into making dtbs_check
> for "my" DTS files clean ;-)
> I hope one of the Dialog/Renesas PMIC people can point me to a better
> address. Steve Twiss sent a goodbye message to some kernel people
> and lkml three years ago, but it is not on lore, as it contained HTML.
>
> Ah, according to git log, David and Adam touched some of the files
> lately, so perhaps they can help?

It'd be great if one of them could volunteer, aye. I do feel like I
recall seeing one of the folks involved with the dialog stuff in
mainline stepping down shortly after the merger though :|


Attachments:
(No filename) (1.05 kB)
signature.asc (235.00 B)
Download all attachments

2023-10-24 19:11:33

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: regulator: dlg,da9210: Convert to json-schema

On Mon, 23 Oct 2023 11:04:45 +0200, Geert Uytterhoeven wrote:
> Convert the Dialog Semiconductor DA9210 Multi-Phase 12A DC-DC Buck
> Converter Device Tree binding documentation to json-schema.
>
>

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] dt-bindings: regulator: dlg,da9210: Convert to json-schema
commit: 7a198e0d48167db90e50777aab5a83a74e351f71

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark