2003-11-26 09:29:36

by yuval yeret

[permalink] [raw]
Subject: 2.4.20-18 size-4096 memory leaks

Hi,

I'm seeing a constant leak in size-4096 on a machine running 2.4.20-18 SMP
BIGMEM, which might / might not be related to the machine finally going out
of memory and going into a hang.

I saw a discussion around similar problems in 2.6.0 (2.6.0-test5/6 (and
probably 7 too) size-4096 memory leak - http://lkml.org/lkml/2003/10/17/5 )
and an ext3 patch was suggested by Andrew Morton.

>From a brief look the code in 2.4 it seems like the patch might be relevant
here as well. Is the size-4096 leak a known issue for 2.4 ?
Is the 2.6 patch applicable in 2.4 as well ?


Thanks,

--
Yuval Yeret
Yuval at exanet dot com
Exanet
http://www.exanet.com

_________________________________________________________________
The new MSN 8: smart spam protection and 2 months FREE*
http://join.msn.com/?page=features/junkmail


2003-11-26 10:11:50

by Henrik Storner

[permalink] [raw]
Subject: Re: 2.4.20-18 size-4096 memory leaks

In <[email protected]> "yuval yeret" <[email protected]> writes:

>I'm seeing a constant leak in size-4096 on a machine running 2.4.20-18 SMP
>BIGMEM, which might / might not be related to the machine finally going out
>of memory and going into a hang.

This sounds like one of the Red Hat kernels - those are immensely
patched and very different from the original Linux kernels normally
discussed here.

However ...

>I saw a discussion around similar problems in 2.6.0 (2.6.0-test5/6 (and
>probably 7 too) size-4096 memory leak - http://lkml.org/lkml/2003/10/17/5 )
>and an ext3 patch was suggested by Andrew Morton.

>From a brief look the code in 2.4 it seems like the patch might be relevant
>here as well. Is the size-4096 leak a known issue for 2.4 ?
>Is the 2.6 patch applicable in 2.4 as well ?

There definitely is a memory leak in the Red Hat 9 kernels, including
the 2.4.20-20.9smp kernel (seems to be in the uniprocessor build as well).
It leaks mm_struct slabs - see the trend graphs I do from the slabinfo
data, available at

http://tyge.sslug.dk/bb-cgi/larrd-grapher.cgi?host=tyge.sslug.dk&service=slabinfo

The blue curve is the mm_struct slab allocation (column 5, the "active
pages" column from /proc/slabinfo) - the way it continually grows from
the system is rebooted IMHO points to a memory leak somewhere. This is
very clear from the third graph, which goes back the last 48 days,
during which we had two reboots of the system (hardware related).

The standard kernels from http://www.kernel.org do not have this problem,
so I am fairly certain it is in one of the Red Hat patches.

Others also see it:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=91090


Henrik
--
Henrik Storner <[email protected]>

2003-11-26 11:51:08

by Stephen C. Tweedie

[permalink] [raw]
Subject: Re: 2.4.20-18 size-4096 memory leaks

Hi,

On Wed, 2003-11-26 at 09:29, yuval yeret wrote:

> I saw a discussion around similar problems in 2.6.0 (2.6.0-test5/6 (and
> probably 7 too) size-4096 memory leak - http://lkml.org/lkml/2003/10/17/5 )
> and an ext3 patch was suggested by Andrew Morton.
>
> From a brief look the code in 2.4 it seems like the patch might be relevant
> here as well. Is the size-4096 leak a known issue for 2.4 ?
> Is the 2.6 patch applicable in 2.4 as well ?

No. The journal_release_buffer() code is not used, or even enabled, on
2.4. There is one set of patches which can use it on 2.4 --- the EA/ACL
code does, but only for extended attributes, and the leak mentioned
above only affects release_buffer() on bitmap buffers.

Cheers,
Stephen