2010-08-14 11:30:03

by Gabor Z. Papp

[permalink] [raw]
Subject: Re:2.6.27.52 stable review


Attachments:
(No filename) (252.00 B)
Makefile.diff (897.00 B)
Download all attachments

2010-08-14 15:01:03

by Grant Coady

[permalink] [raw]
Subject: Re: 2.6.27.52 stable review

On Sat, 14 Aug 2010 13:11:43 +0200, you wrote:

>* Greg KH <[email protected]>:
>
>| If I could get some people to please test this -rc release?
>
>BTW seems like 2.6.27 no more combatible with GNU Make 3.82:
>
>$ make oldconfig
>Makefile:443: *** mixed implicit and normal rules. Stop.
>
>Same with line 1609.

I have:
grant@deltree:~$ make --version
GNU Make 3.81
Copyright (C) 2006 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.

This program built for i486-slackware-linux-gnu

and 2.6.27 builds here just fine.

Grant.

2010-08-14 21:40:02

by Greg KH

[permalink] [raw]
Subject: Re: 2.6.27.52 stable review

On Sat, Aug 14, 2010 at 01:11:43PM +0200, Gabor Z. Papp wrote:
> * Greg KH <[email protected]>:
>
> | If I could get some people to please test this -rc release?
>
> BTW seems like 2.6.27 no more combatible with GNU Make 3.82:
>
> $ make oldconfig
> Makefile:443: *** mixed implicit and normal rules. Stop.
>
> Same with line 1609.

Nothing has changed with the main Makefile with the exception of
changing the version number for a very long time.

Did something else change on your system?

odd,

greg k-h

2010-08-14 22:11:38

by Thomas Backlund

[permalink] [raw]
Subject: Re: 2.6.27.52 stable review

Greg KH skrev 15.8.2010 00:01:
> On Sat, Aug 14, 2010 at 01:11:43PM +0200, Gabor Z. Papp wrote:
>> * Greg KH<[email protected]>:
>>
>> | If I could get some people to please test this -rc release?
>>
>> BTW seems like 2.6.27 no more combatible with GNU Make 3.82:
>>
>> $ make oldconfig
>> Makefile:443: *** mixed implicit and normal rules. Stop.
>>
>> Same with line 1609.
>
> Nothing has changed with the main Makefile with the exception of
> changing the version number for a very long time.
>
> Did something else change on your system?
>
> odd,
>

2.6.27 needs this wich went in after 2.6.28-rc8:

kbuild: fix make incompatibility
author Sam Ravnborg <[email protected]>
Sat, 13 Dec 2008 22:00:45 +0000 (23:00 +0100)
committer Sam Ravnborg <[email protected]>
Sat, 13 Dec 2008 22:00:45 +0000 (23:00 +0100)
commit 31110ebbec8688c6e9597b641101afc94e1c762a
tree 208aaad7e40cbb86bc125760664911da8cd4eebb tree | snapshot
parent abf681ce5b6f83f0b8883e0f2c12d197a38543dd commit | diff
kbuild: fix make incompatibility

"Paul Smith" <[email protected]> reported that we would fail
to build with a new check that may be enabled in an
upcoming version of make.

The error was:

Makefile:442: *** mixed implicit and normal rules. Stop.


And I assume the powerpc make-3.82 fix
(e32e78c5ee8aadef020fbaecbe6fb741ed9029fd)
needs to be added to 2.6.27 too...

--
Thomas

2010-08-23 22:47:05

by Greg KH

[permalink] [raw]
Subject: Re: 2.6.27.52 stable review

On Sun, Aug 15, 2010 at 01:11:35AM +0300, Thomas Backlund wrote:
> Greg KH skrev 15.8.2010 00:01:
> >On Sat, Aug 14, 2010 at 01:11:43PM +0200, Gabor Z. Papp wrote:
> >>* Greg KH<[email protected]>:
> >>
> >>| If I could get some people to please test this -rc release?
> >>
> >>BTW seems like 2.6.27 no more combatible with GNU Make 3.82:
> >>
> >>$ make oldconfig
> >>Makefile:443: *** mixed implicit and normal rules. Stop.
> >>
> >>Same with line 1609.
> >
> >Nothing has changed with the main Makefile with the exception of
> >changing the version number for a very long time.
> >
> >Did something else change on your system?
> >
> >odd,
> >
>
> 2.6.27 needs this wich went in after 2.6.28-rc8:
>
> kbuild: fix make incompatibility
> author Sam Ravnborg <[email protected]>
> Sat, 13 Dec 2008 22:00:45 +0000 (23:00 +0100)
> committer Sam Ravnborg <[email protected]>
> Sat, 13 Dec 2008 22:00:45 +0000 (23:00 +0100)
> commit 31110ebbec8688c6e9597b641101afc94e1c762a

Now applied.

thanks,

greg k-h