2003-03-25 04:10:24

by Miles Bader

[permalink] [raw]
Subject: !CONFIG_MMU stubs in 2.5.66

The following change in 2.5.66:

[PATCH] a few missing stubs for !CONFIG_MMU

Patch from Christoph Hellwig <[email protected]>

This is from the uClinux patches - there are a few more stubs needed
in nommu.c to get the mmuless plattforms working.

Adds definitions for vmalloc_to_page, follow_page, and remap_page_range,
to mm/mmnommu.c. However, there are already inline definitions of those
functions (predicated on !CONFIG_MMU) in linux/mm.h, so compilation
fails.

Which is the correct location?

[I locally removed the defs in linux/mm.h to get things to compile]

Thanks,

-Miles
--
[|nurgle|] ddt- demonic? so quake will have an evil kinda setting? one that
will make every christian in the world foamm at the mouth?
[iddt] nurg, that's the goal


2003-03-25 06:36:35

by Christoph Hellwig

[permalink] [raw]
Subject: Re: !CONFIG_MMU stubs in 2.5.66

On Tue, Mar 25, 2003 at 01:20:16PM +0900, Miles Bader wrote:
> The following change in 2.5.66:
>
> [PATCH] a few missing stubs for !CONFIG_MMU
>
> Patch from Christoph Hellwig <[email protected]>
>
> This is from the uClinux patches - there are a few more stubs needed
> in nommu.c to get the mmuless plattforms working.
>
> Adds definitions for vmalloc_to_page, follow_page, and remap_page_range,
> to mm/mmnommu.c. However, there are already inline definitions of those
> functions (predicated on !CONFIG_MMU) in linux/mm.h, so compilation
> fails.
>
> Which is the correct location?

OOPS, it looks like Greg & me submitted paches in parallel. Personally I
prefer the out of line ones over the inlines, especially as they handle
vmalloc_to_page properly. I'll submit a patch to Linus to fix this
mess.