2004-10-28 22:13:10

by Adrian Bunk

Subject: [2.6 patch] appletalk: remove an unused function

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

The patch below removes an unsed function from net/appletalk/ddp.c


diffstat output:
net/appletalk/ddp.c | 7 -------
1 files changed, 7 deletions(-)


Signed-off-by: Adrian Bunk <[email protected]>

- --- linux-2.6.10-rc1-mm1-full/net/appletalk/ddp.c.old 2004-10-28 23:49:44.000000000 +0200
+++ linux-2.6.10-rc1-mm1-full/net/appletalk/ddp.c 2004-10-28 23:49:57.000000000 +0200
@@ -78,13 +78,6 @@
sk_add_node(sk, &atalk_sockets);
}

- -static inline void atalk_insert_socket(struct sock *sk)
- -{
- - write_lock_bh(&atalk_sockets_lock);
- - __atalk_insert_socket(sk);
- - write_unlock_bh(&atalk_sockets_lock);
- -}
- -
static inline void atalk_remove_socket(struct sock *sk)
{
write_lock_bh(&atalk_sockets_lock);

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)

iD8DBQFBgW5mmfzqmE8StAARAvaMAJ94zqUtcUYZKMtwHKnTtKof9ew9pACeJIoT
d7KwwwKipvnGxnCmnwf8U0E=
=xXRj
-----END PGP SIGNATURE-----

2004-10-29 01:57:36

by Adrian Bunk

Subject: [2.6 patch] appletalk: remove an unused function

[ this time without the problems due to a digital signature... ]

The patch below removes an unsed function from net/appletalk/ddp.c


diffstat output:
net/appletalk/ddp.c | 7 -------
1 files changed, 7 deletions(-)


Signed-off-by: Adrian Bunk <[email protected]>

--- linux-2.6.10-rc1-mm1-full/net/appletalk/ddp.c.old 2004-10-28 23:49:44.000000000 +0200
+++ linux-2.6.10-rc1-mm1-full/net/appletalk/ddp.c 2004-10-28 23:49:57.000000000 +0200
@@ -78,13 +78,6 @@
sk_add_node(sk, &atalk_sockets);
}

-static inline void atalk_insert_socket(struct sock *sk)
-{
- write_lock_bh(&atalk_sockets_lock);
- __atalk_insert_socket(sk);
- write_unlock_bh(&atalk_sockets_lock);
-}
-
static inline void atalk_remove_socket(struct sock *sk)
{
write_lock_bh(&atalk_sockets_lock);

2004-10-28 23:57:51

by David Miller

Subject: Re: [2.6 patch] appletalk: remove an unused function

On Fri, 29 Oct 2004 00:10:46 +0200
Adrian Bunk <[email protected]> wrote:

> - -static inline void atalk_insert_socket(struct sock *sk)
> - -{
> - - write_lock_bh(&atalk_sockets_lock);
> - - __atalk_insert_socket(sk);
> - - write_unlock_bh(&atalk_sockets_lock);
> - -}
> - -

This is a patch of a patch, I doubt it will apply cleanly ;-)

2004-10-29 02:36:37

by Jeff Garzik

Subject: Re: [2.6 patch] appletalk: remove an unused function

On Thu, Oct 28, 2004 at 04:26:43PM -0700, David S. Miller wrote:
> On Fri, 29 Oct 2004 00:10:46 +0200
> Adrian Bunk <[email protected]> wrote:
>
> > - -static inline void atalk_insert_socket(struct sock *sk)
> > - -{
> > - - write_lock_bh(&atalk_sockets_lock);
> > - - __atalk_insert_socket(sk);
> > - - write_unlock_bh(&atalk_sockets_lock);
> > - -}
> > - -
>
> This is a patch of a patch, I doubt it will apply cleanly ;-)

Ditto, all the patches sent to me look like this, too.

Jeff

2004-10-29 02:59:17

by Miles Bader

Subject: Re: [2.6 patch] appletalk: remove an unused function

"David S. Miller" <[email protected]> writes:
> This is a patch of a patch, I doubt it will apply cleanly ;-)

Note if you run it through gpg/pgp decoding it will output the real
patch (my mail client does this automatically, so the comments saying
the patches were screwed up were very confusing at first!).

-Miles
--
Run away! Run away!

2004-11-02 00:42:33

by David Miller

Subject: Re: [2.6 patch] appletalk: remove an unused function

On Fri, 29 Oct 2004 02:14:39 +0200
Adrian Bunk <[email protected]> wrote:

> The patch below removes an unsed function from net/appletalk/ddp.c

Applied, thanks Adrian.