2003-03-13 13:18:51

by Andrey Panin

[permalink] [raw]

Subject: [PATCH] irq handling code consolidation (v850 part)

---

Hi,

irq handling code consolidation continues.

v850 specific patch attached. Untested.

Best regards.

--
Andrey Panin | Embedded systems software developer
[email protected] | PGP key: wwwkeys.pgp.net

---

Attachments:

(No filename) (205.00 B)
patch-irq-v850-2.5.64 (15.67 kB)
Download all attachments

2003-03-14 04:02:30

by Miles Bader

[permalink] [raw]

Subject: Re: [PATCH] irq handling code consolidation (v850 part)

---

Andrey Panin <[email protected]> writes:
> irq handling code consolidation continues.
> v850 specific patch attached. Untested.

Works great on the v850.

Here's a small v850 tweak that you might add to your patch (fixes one
printf warning, removes an unused variable):


diff -up linux-2.5.64-moo/arch/v850/kernel/irq.c.\~1\~ linux-2.5.64-moo/arch/v850/kernel/irq.c
--- linux-2.5.64-moo/arch/v850/kernel/irq.c.~1~ 2003-03-14 10:39:25.000000000 +0900
+++ linux-2.5.64-moo/arch/v850/kernel/irq.c 2003-03-14 10:50:41.000000000 +0900
@@ -27,8 +27,6 @@

extern atomic_t irq_err_count;

-volatile unsigned long spurious_count;
-
/*
* Generic, controller-independent functions:
*/
@@ -73,7 +71,9 @@ int show_interrupts(struct seq_file *p,
seq_printf(p, ", %s", action->name);
seq_putc(p, '\n');
}
- seq_printf(p, "ERR: %10lu\n", atomic_read(&irq_err_count));
+
+ seq_printf(p, "ERR: %10u\n", atomic_read(&irq_err_count));
+
return 0;
}


Thanks,

-Miles
--
Fast, small, soon; pick any 2.