2021-08-16 11:32:14

by CGEL

Subject: [PATCH linux-next] module: remove duplicate include in interrupt.c

From: Lv Ruyi <[email protected]>

'asm/interrupt.h' included in 'interrupt.c' is duplicated.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Lv Ruyi <[email protected]>
---
arch/arm/mach-sa1100/hackkit.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm/mach-sa1100/hackkit.c b/arch/arm/mach-sa1100/hackkit.c
index 3085f1c2e586..3fe34ee7c0ab 100644
--- a/arch/arm/mach-sa1100/hackkit.c
+++ b/arch/arm/mach-sa1100/hackkit.c
@@ -18,7 +18,6 @@
#include <linux/serial_core.h>
#include <linux/mtd/mtd.h>
#include <linux/mtd/partitions.h>
-#include <linux/tty.h>
#include <linux/gpio.h>
#include <linux/leds.h>
#include <linux/platform_device.h>
--
2.25.1

2021-08-17 11:58:45

by Zenghui Yu

Subject: Re: [PATCH linux-next] module: remove duplicate include in interrupt.c

On 2021/8/16 19:29, [email protected] wrote:
> From: Lv Ruyi <[email protected]>
>
> 'asm/interrupt.h' included in 'interrupt.c' is duplicated.

Sorry but this obviously doesn't match with the change you've made.

>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Lv Ruyi <[email protected]>
> ---
> arch/arm/mach-sa1100/hackkit.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mach-sa1100/hackkit.c b/arch/arm/mach-sa1100/hackkit.c
> index 3085f1c2e586..3fe34ee7c0ab 100644
> --- a/arch/arm/mach-sa1100/hackkit.c
> +++ b/arch/arm/mach-sa1100/hackkit.c
> @@ -18,7 +18,6 @@
> #include <linux/serial_core.h>
> #include <linux/mtd/mtd.h>
> #include <linux/mtd/partitions.h>
> -#include <linux/tty.h>
> #include <linux/gpio.h>
> #include <linux/leds.h>
> #include <linux/platform_device.h>
>