In a future patch HAS_IOPORT=n will disable inb()/outb() and friends at
compile time. As hexagon does not support I/O port access it also
the GENERIC_IOMAP mechanism of dynamically choosing between I/O port and
MMIO access doesn't work so don't select it.
Co-developed-by: Arnd Bergmann <[email protected]>
Signed-off-by: Arnd Bergmann <[email protected]>
Signed-off-by: Niklas Schnelle <[email protected]>
---
arch/hexagon/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/hexagon/Kconfig b/arch/hexagon/Kconfig
index e233b5efa276..5ea1bf4b7d4f 100644
--- a/arch/hexagon/Kconfig
+++ b/arch/hexagon/Kconfig
@@ -31,7 +31,6 @@ config HEXAGON
select HAVE_ARCH_TRACEHOOK
select NEED_SG_DMA_LENGTH
select NO_IOPORT_MAP
- select GENERIC_IOMAP
select GENERIC_IOREMAP
select GENERIC_SMP_IDLE_THREAD
select STACKTRACE_SUPPORT
--
2.40.1
> -----Original Message-----
> From: Niklas Schnelle <[email protected]>
> Sent: Wednesday, April 3, 2024 8:25 AM
> To: Brian Cain <[email protected]>
> Cc: [email protected]; Arnd Bergmann <[email protected]>;
> Heiko Carstens <[email protected]>; [email protected]; Niklas
> Schnelle <[email protected]>
> Subject: [PATCH 1/1] hexagon: Don't select GENERIC_IOMAP without
> HAS_IOPORT support
>
> WARNING: This email originated from outside of Qualcomm. Please be wary
> of any links or attachments, and do not enable macros.
>
> In a future patch HAS_IOPORT=n will disable inb()/outb() and friends at
> compile time. As hexagon does not support I/O port access it also
> the GENERIC_IOMAP mechanism of dynamically choosing between I/O port
> and
> MMIO access doesn't work so don't select it.
>
> Co-developed-by: Arnd Bergmann <[email protected]>
> Signed-off-by: Arnd Bergmann <[email protected]>
> Signed-off-by: Niklas Schnelle <[email protected]>
> ---
> arch/hexagon/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/hexagon/Kconfig b/arch/hexagon/Kconfig
> index e233b5efa276..5ea1bf4b7d4f 100644
> --- a/arch/hexagon/Kconfig
> +++ b/arch/hexagon/Kconfig
> @@ -31,7 +31,6 @@ config HEXAGON
> select HAVE_ARCH_TRACEHOOK
> select NEED_SG_DMA_LENGTH
> select NO_IOPORT_MAP
> - select GENERIC_IOMAP
> select GENERIC_IOREMAP
> select GENERIC_SMP_IDLE_THREAD
> select STACKTRACE_SUPPORT
Reviewed-by: Brian Cain <[email protected]>
> --
> 2.40.1
On Wed, 2024-04-03 at 14:51 +0000, Brian Cain wrote:
>
> > -----Original Message-----
> > From: Niklas Schnelle <[email protected]>
> > Sent: Wednesday, April 3, 2024 8:25 AM
> > To: Brian Cain <[email protected]>
> > Cc: [email protected]; Arnd Bergmann <[email protected]>;
> > Heiko Carstens <[email protected]>; [email protected]; Niklas
> > Schnelle <[email protected]>
> > Subject: [PATCH 1/1] hexagon: Don't select GENERIC_IOMAP without
> > HAS_IOPORT support
> >
> > WARNING: This email originated from outside of Qualcomm. Please be wary
> > of any links or attachments, and do not enable macros.
> >
> > In a future patch HAS_IOPORT=n will disable inb()/outb() and friends at
> > compile time. As hexagon does not support I/O port access it also
> > the GENERIC_IOMAP mechanism of dynamically choosing between I/O port
> > and
> > MMIO access doesn't work so don't select it.
> >
> > Co-developed-by: Arnd Bergmann <[email protected]>
> > Signed-off-by: Arnd Bergmann <[email protected]>
> > Signed-off-by: Niklas Schnelle <[email protected]>
> > ---
> > arch/hexagon/Kconfig | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/hexagon/Kconfig b/arch/hexagon/Kconfig
> > index e233b5efa276..5ea1bf4b7d4f 100644
> > --- a/arch/hexagon/Kconfig
> > +++ b/arch/hexagon/Kconfig
> > @@ -31,7 +31,6 @@ config HEXAGON
> > select HAVE_ARCH_TRACEHOOK
> > select NEED_SG_DMA_LENGTH
> > select NO_IOPORT_MAP
> > - select GENERIC_IOMAP
> > select GENERIC_IOREMAP
> > select GENERIC_SMP_IDLE_THREAD
> > select STACKTRACE_SUPPORT
>
> Reviewed-by: Brian Cain <[email protected]>
>
Thanks for the R-b, which tree should take this? If you have other
hexagon changes for v6.10 I think it would be easiest to take this
together with those. As mentioned in the cover letter the per-subsystem
changes are all independent until HAS_IOPORT=n actually disables
inb()/outb() which Arnd will take once all the subsystems are covered.
Thanks,
Niklas
> -----Original Message-----
> From: Niklas Schnelle <[email protected]>
> Sent: Wednesday, April 3, 2024 10:22 AM
> To: Brian Cain <[email protected]>
> Cc: [email protected]; Arnd Bergmann <[email protected]>;
> Heiko Carstens <[email protected]>; [email protected]
> Subject: Re: [PATCH 1/1] hexagon: Don't select GENERIC_IOMAP without
> HAS_IOPORT support
>
> WARNING: This email originated from outside of Qualcomm. Please be wary
> of any links or attachments, and do not enable macros.
>
> On Wed, 2024-04-03 at 14:51 +0000, Brian Cain wrote:
> >
> > > -----Original Message-----
> > > From: Niklas Schnelle <[email protected]>
> > > Sent: Wednesday, April 3, 2024 8:25 AM
> > > To: Brian Cain <[email protected]>
> > > Cc: [email protected]; Arnd Bergmann <[email protected]>;
> > > Heiko Carstens <[email protected]>; [email protected];
> Niklas
> > > Schnelle <[email protected]>
> > > Subject: [PATCH 1/1] hexagon: Don't select GENERIC_IOMAP without
> > > HAS_IOPORT support
> > >
> > > WARNING: This email originated from outside of Qualcomm. Please be
> wary
> > > of any links or attachments, and do not enable macros.
> > >
> > > In a future patch HAS_IOPORT=n will disable inb()/outb() and friends at
> > > compile time. As hexagon does not support I/O port access it also
> > > the GENERIC_IOMAP mechanism of dynamically choosing between I/O
> port
> > > and
> > > MMIO access doesn't work so don't select it.
> > >
> > > Co-developed-by: Arnd Bergmann <[email protected]>
> > > Signed-off-by: Arnd Bergmann <[email protected]>
> > > Signed-off-by: Niklas Schnelle <[email protected]>
> > > ---
> > > arch/hexagon/Kconfig | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > diff --git a/arch/hexagon/Kconfig b/arch/hexagon/Kconfig
> > > index e233b5efa276..5ea1bf4b7d4f 100644
> > > --- a/arch/hexagon/Kconfig
> > > +++ b/arch/hexagon/Kconfig
> > > @@ -31,7 +31,6 @@ config HEXAGON
> > > select HAVE_ARCH_TRACEHOOK
> > > select NEED_SG_DMA_LENGTH
> > > select NO_IOPORT_MAP
> > > - select GENERIC_IOMAP
> > > select GENERIC_IOREMAP
> > > select GENERIC_SMP_IDLE_THREAD
> > > select STACKTRACE_SUPPORT
> >
> > Reviewed-by: Brian Cain <[email protected]>
> >
>
> Thanks for the R-b, which tree should take this? If you have other
> hexagon changes for v6.10 I think it would be easiest to take this
> together with those. As mentioned in the cover letter the per-subsystem
I don't have other changes planned for v6.10 but I'm happy to take the change in my tree.
> changes are all independent until HAS_IOPORT=n actually disables
> inb()/outb() which Arnd will take once all the subsystems are covered.
>
> Thanks,
> Niklas