2022-12-20 13:19:37

by Michael S. Tsirkin

[permalink] [raw]
Subject: [PATCH] virtio_blk: zone append in header type tweak

virtio blk returns a 64 bit append_sector in an input buffer,
in LE format. This field is not tagged as LE correctly, so
even though the generated code is ok, we get warnings from sparse:

drivers/block/virtio_blk.c:332:33: sparse: sparse: cast to restricted __le64

Make sparse happy by using the correct type.

Signed-off-by: Michael S. Tsirkin <[email protected]>
---
drivers/block/virtio_blk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
index 73cd5db0d7d5..dc577e8bfa30 100644
--- a/drivers/block/virtio_blk.c
+++ b/drivers/block/virtio_blk.c
@@ -104,7 +104,7 @@ struct virtblk_req {
struct {
u8 status;
u8 reserved[7];
- u64 append_sector;
+ __le64 append_sector;
} zone_append_in_hdr;
};

--
MST


2022-12-20 20:11:36

by Stefan Hajnoczi

[permalink] [raw]
Subject: Re: [PATCH] virtio_blk: zone append in header type tweak

On Tue, Dec 20, 2022 at 07:52:01AM -0500, Michael S. Tsirkin wrote:
> virtio blk returns a 64 bit append_sector in an input buffer,
> in LE format. This field is not tagged as LE correctly, so
> even though the generated code is ok, we get warnings from sparse:
>
> drivers/block/virtio_blk.c:332:33: sparse: sparse: cast to restricted __le64
>
> Make sparse happy by using the correct type.
>
> Signed-off-by: Michael S. Tsirkin <[email protected]>
> ---
> drivers/block/virtio_blk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Stefan Hajnoczi <[email protected]>


Attachments:
(No filename) (609.00 B)
signature.asc (499.00 B)
Download all attachments

2022-12-20 22:57:52

by Chaitanya Kulkarni

[permalink] [raw]
Subject: Re: [PATCH] virtio_blk: zone append in header type tweak

On 12/20/22 04:52, Michael S. Tsirkin wrote:
> virtio blk returns a 64 bit append_sector in an input buffer,
> in LE format. This field is not tagged as LE correctly, so
> even though the generated code is ok, we get warnings from sparse:
>
> drivers/block/virtio_blk.c:332:33: sparse: sparse: cast to restricted __le64
>
> Make sparse happy by using the correct type.
>

Reviewed-by: Chaitanya Kulkarni <[email protected]>

-ck