2022-07-08 19:46:34

by Christophe JAILLET

Subject: [PATCH] firmware: arm_scmi: Use the bitmap API to allocate bitmaps

Use devm_bitmap_zalloc() instead of hand-writing them.

It is less verbose and it improves the semantic.

Signed-off-by: Christophe JAILLET <[email protected]>
---
drivers/firmware/arm_scmi/driver.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c
index 609ebedee9cb..b1265732d83a 100644
--- a/drivers/firmware/arm_scmi/driver.c
+++ b/drivers/firmware/arm_scmi/driver.c
@@ -1911,8 +1911,8 @@ static int __scmi_xfer_info_init(struct scmi_info *sinfo,
hash_init(info->pending_xfers);

/* Allocate a bitmask sized to hold MSG_TOKEN_MAX tokens */
- info->xfer_alloc_table = devm_kcalloc(dev, BITS_TO_LONGS(MSG_TOKEN_MAX),
- sizeof(long), GFP_KERNEL);
+ info->xfer_alloc_table = devm_bitmap_zalloc(dev, MSG_TOKEN_MAX,
+ GFP_KERNEL);
if (!info->xfer_alloc_table)
return -ENOMEM;

--
2.34.1

2022-07-13 11:04:08

by Cristian Marussi

Subject: Re: [PATCH] firmware: arm_scmi: Use the bitmap API to allocate bitmaps

On Fri, Jul 08, 2022 at 09:30:01PM +0200, Christophe JAILLET wrote:
> Use devm_bitmap_zalloc() instead of hand-writing them.
>
> It is less verbose and it improves the semantic.
>
> Signed-off-by: Christophe JAILLET <[email protected]>
> ---
> drivers/firmware/arm_scmi/driver.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c
> index 609ebedee9cb..b1265732d83a 100644
> --- a/drivers/firmware/arm_scmi/driver.c
> +++ b/drivers/firmware/arm_scmi/driver.c
> @@ -1911,8 +1911,8 @@ static int __scmi_xfer_info_init(struct scmi_info *sinfo,
> hash_init(info->pending_xfers);
>
> /* Allocate a bitmask sized to hold MSG_TOKEN_MAX tokens */
> - info->xfer_alloc_table = devm_kcalloc(dev, BITS_TO_LONGS(MSG_TOKEN_MAX),
> - sizeof(long), GFP_KERNEL);
> + info->xfer_alloc_table = devm_bitmap_zalloc(dev, MSG_TOKEN_MAX,
> + GFP_KERNEL);
> if (!info->xfer_alloc_table)
> return -ENOMEM;
>
LGTM.

Reviewed-by: Cristian Marussi <[email protected]>
Tested-by: Cristian Marussi <[email protected]>

Thanks,
Cristian

2023-03-20 11:20:09

by Sudeep Holla

Subject: Re: [PATCH] firmware: arm_scmi: Use the bitmap API to allocate bitmaps

On Fri, 08 Jul 2022 21:30:01 +0200, Christophe JAILLET wrote:
> Use devm_bitmap_zalloc() instead of hand-writing them.
>
> It is less verbose and it improves the semantic.
>

(sorry for the delay, it seemed to have slipped through the cracks,
thanks to Cristian for pointing this out)

Applied to sudeep.holla/linux (for-next/scmi/fixes), thanks!

[1/1] firmware: arm_scmi: Use the bitmap API to allocate bitmaps
https://git.kernel.org/sudeep.holla/c/d617808e3b83
--
Regards,
Sudeep