Add generic Sunplus SP7021 based board defconfig
Reviewed-by: Arnd Bergmann <[email protected]>
Signed-off-by: Qin Jian <[email protected]>
---
MAINTAINERS | 1 +
arch/arm/configs/multi_v7_defconfig | 1 +
arch/arm/configs/sp7021_defconfig | 61 +++++++++++++++++++++++++++++
3 files changed, 63 insertions(+)
create mode 100644 arch/arm/configs/sp7021_defconfig
diff --git a/MAINTAINERS b/MAINTAINERS
index 38890c055..93f4de6c1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2747,6 +2747,7 @@ F: Documentation/devicetree/bindings/arm/sunplus,sp7021.yaml
F: Documentation/devicetree/bindings/clock/sunplus,sp7021-clkc.yaml
F: Documentation/devicetree/bindings/interrupt-controller/sunplus,sp7021-intc.yaml
F: Documentation/devicetree/bindings/reset/sunplus,reset.yaml
+F: arch/arm/configs/sp7021_*defconfig
F: arch/arm/mach-sunplus/
F: drivers/clk/clk-sp7021.c
F: drivers/irqchip/irq-sp7021-intc.c
diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 8863fa969..a3bd9dbd8 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -86,6 +86,7 @@ CONFIG_MACH_SPEAR1310=y
CONFIG_MACH_SPEAR1340=y
CONFIG_ARCH_STI=y
CONFIG_ARCH_STM32=y
+CONFIG_ARCH_SUNPLUS=y
CONFIG_ARCH_SUNXI=y
CONFIG_ARCH_TEGRA=y
CONFIG_ARCH_UNIPHIER=y
diff --git a/arch/arm/configs/sp7021_defconfig b/arch/arm/configs/sp7021_defconfig
new file mode 100644
index 000000000..cda16d33a
--- /dev/null
+++ b/arch/arm/configs/sp7021_defconfig
@@ -0,0 +1,61 @@
+CONFIG_SYSVIPC=y
+CONFIG_NO_HZ_IDLE=y
+CONFIG_HIGH_RES_TIMERS=y
+CONFIG_PREEMPT=y
+CONFIG_IKCONFIG=y
+CONFIG_IKCONFIG_PROC=y
+CONFIG_LOG_BUF_SHIFT=14
+# CONFIG_RD_GZIP is not set
+# CONFIG_RD_BZIP2 is not set
+# CONFIG_RD_LZMA is not set
+# CONFIG_RD_XZ is not set
+# CONFIG_RD_LZO is not set
+# CONFIG_RD_LZ4 is not set
+CONFIG_CC_OPTIMIZE_FOR_SIZE=y
+CONFIG_PERF_EVENTS=y
+CONFIG_SLAB=y
+CONFIG_ARCH_SUNPLUS=y
+# CONFIG_VDSO is not set
+CONFIG_SMP=y
+CONFIG_HAVE_ARM_ARCH_TIMER=y
+CONFIG_THUMB2_KERNEL=y
+CONFIG_FORCE_MAX_ZONEORDER=12
+CONFIG_VFP=y
+CONFIG_NEON=y
+CONFIG_MODULES=y
+CONFIG_MODULE_UNLOAD=y
+CONFIG_MODVERSIONS=y
+# CONFIG_CORE_DUMP_DEFAULT_ELF_HEADERS is not set
+CONFIG_UEVENT_HELPER=y
+CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug"
+CONFIG_DEVTMPFS=y
+CONFIG_DEVTMPFS_MOUNT=y
+CONFIG_BLK_DEV_LOOP=y
+CONFIG_INPUT_SPARSEKMAP=y
+CONFIG_INPUT_EVDEV=y
+# CONFIG_INPUT_KEYBOARD is not set
+# CONFIG_INPUT_MOUSE is not set
+# CONFIG_LEGACY_PTYS is not set
+# CONFIG_HW_RANDOM is not set
+# CONFIG_HWMON is not set
+CONFIG_STAGING=y
+# CONFIG_IOMMU_SUPPORT is not set
+CONFIG_RESET_CONTROLLER=y
+CONFIG_EXT4_FS=y
+# CONFIG_DNOTIFY is not set
+CONFIG_FANOTIFY=y
+CONFIG_VFAT_FS=y
+CONFIG_FAT_DEFAULT_IOCHARSET="utf8"
+CONFIG_EXFAT_FS=y
+CONFIG_TMPFS=y
+CONFIG_TMPFS_POSIX_ACL=y
+# CONFIG_MISC_FILESYSTEMS is not set
+CONFIG_NLS_CODEPAGE_437=y
+CONFIG_NLS_ASCII=y
+CONFIG_NLS_ISO8859_1=y
+CONFIG_NLS_UTF8=y
+CONFIG_PRINTK_TIME=y
+CONFIG_DYNAMIC_DEBUG=y
+CONFIG_MAGIC_SYSRQ=y
+CONFIG_DEBUG_FS=y
+CONFIG_DEBUG_USER=y
--
2.33.1
On Tue, Mar 22, 2022 at 7:17 AM Qin Jian <[email protected]> wrote:
>
> Add generic Sunplus SP7021 based board defconfig
>
> Reviewed-by: Arnd Bergmann <[email protected]>
> Signed-off-by: Qin Jian <[email protected]>
I don't think I ever replied with 'Reviewed-by: Arnd Bergmann <[email protected]>'
to this patch. While I did review it in version 5, you never seem to have
replied to my questions there.
It was a while ago though, so I don't remember the details, if we did
conclude the review, can you link to the lore.kernel.org thread in
the next version? Please also check the other patches on which
you added a 'Reviewed-by' tag from someone to ensure that they
actually provided that tag, rather than just providing review comments.
Arnd
> On Tue, Mar 22, 2022 at 7:17 AM Qin Jian <[email protected]> wrote:
> >
> > Add generic Sunplus SP7021 based board defconfig
> >
> > Reviewed-by: Arnd Bergmann <[email protected]>
> > Signed-off-by: Qin Jian <[email protected]>
>
> I don't think I ever replied with 'Reviewed-by: Arnd Bergmann <[email protected]>'
> to this patch. While I did review it in version 5, you never seem to have
> replied to my questions there.
>
> It was a while ago though, so I don't remember the details, if we did
> conclude the review, can you link to the lore.kernel.org thread in
> the next version? Please also check the other patches on which
> you added a 'Reviewed-by' tag from someone to ensure that they
> actually provided that tag, rather than just providing review comments.
>
> Arnd
In patch 6, I fixed all your comments.
I got a reply from you: https://lore.kernel.org/all/CAK8P3a1Doh8GY9iFZsvmd6wASHoPqyR+roXx0G5XidnmHNkGaA@mail.gmail.com/
> This looks all good to me now, it just needs a review for the clk,
> reset and irqchip drivers. ...
If these not means you reviewed, I'll remove your review-tag.
On Wed, Mar 23, 2022 at 2:41 AM qinjian[覃健] <[email protected]> wrote:
> > On Tue, Mar 22, 2022 at 7:17 AM Qin Jian <[email protected]> wrote:
> >
> > It was a while ago though, so I don't remember the details, if we did
> > conclude the review, can you link to the lore.kernel.org thread in
> > the next version? Please also check the other patches on which
> > you added a 'Reviewed-by' tag from someone to ensure that they
> > actually provided that tag, rather than just providing review comments.
>
> In patch 6, I fixed all your comments.
>
> I got a reply from you: https://lore.kernel.org/all/CAK8P3a1Doh8GY9iFZsvmd6wASHoPqyR+roXx0G5XidnmHNkGaA@mail.gmail.com/
> > This looks all good to me now, it just needs a review for the clk,
> > reset and irqchip drivers. ...
>
> If these not means you reviewed, I'll remove your review-tag.
You can only add Reviewed-by tags that have been explicitly given,
see the documentation at [1] for details. What I wrote was a less
formal acknowledgement that does not have the specific meaning.
Arnd
[1] https://www.kernel.org/doc/html/latest/translations/zh_TW/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes
> > In patch 6, I fixed all your comments.
> >
> > I got a reply from you:
> https://lore.kernel.org/all/CAK8P3a1Doh8GY9iFZsvmd6wASHoPqyR+roXx0G5XidnmHNkGaA@mail.gmail.com/
> > > This looks all good to me now, it just needs a review for the clk,
> > > reset and irqchip drivers. ...
> >
> > If these not means you reviewed, I'll remove your review-tag.
>
> You can only add Reviewed-by tags that have been explicitly given,
> see the documentation at [1] for details. What I wrote was a less
> formal acknowledgement that does not have the specific meaning.
>
> Arnd
>
> [1] https://www.kernel.org/doc/html/latest/translations/zh_TW/process/submitting-patches.html#using-reported-by-tested-by-
> reviewed-by-suggested-by-and-fixes
Thanks for your comments, I'll remove your tags later.