2022-09-07 03:54:30

by Li zeming

Subject: [PATCH] drm/ttm: Remove unnecessary '0' values from ret

The variable ret is assigned in the judgment branch statement, he does
not need to initialize the assignment.

Signed-off-by: Li zeming <[email protected]>
---
include/drm/ttm/ttm_bo_driver.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/drm/ttm/ttm_bo_driver.h b/include/drm/ttm/ttm_bo_driver.h
index 897b88f0bd59..1afa891f488a 100644
--- a/include/drm/ttm/ttm_bo_driver.h
+++ b/include/drm/ttm/ttm_bo_driver.h
@@ -106,7 +106,7 @@ static inline int ttm_bo_reserve(struct ttm_buffer_object *bo,
bool interruptible, bool no_wait,
struct ww_acquire_ctx *ticket)
{
- int ret = 0;
+ int ret;

if (no_wait) {
bool success;
--
2.18.2

2022-09-07 08:37:03

by Christian König

Subject: Re: [PATCH] drm/ttm: Remove unnecessary '0' values from ret

Am 07.09.22 um 05:29 schrieb Li zeming:
> The variable ret is assigned in the judgment branch statement, he does
> not need to initialize the assignment.
>
> Signed-off-by: Li zeming <[email protected]>

Reviewed and pushed to drm-misc-next.

Thanks,
Christian.

> ---
> include/drm/ttm/ttm_bo_driver.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/drm/ttm/ttm_bo_driver.h b/include/drm/ttm/ttm_bo_driver.h
> index 897b88f0bd59..1afa891f488a 100644
> --- a/include/drm/ttm/ttm_bo_driver.h
> +++ b/include/drm/ttm/ttm_bo_driver.h
> @@ -106,7 +106,7 @@ static inline int ttm_bo_reserve(struct ttm_buffer_object *bo,
> bool interruptible, bool no_wait,
> struct ww_acquire_ctx *ticket)
> {
> - int ret = 0;
> + int ret;
>
> if (no_wait) {
> bool success;