The i.MX GPT timer driver binding doc is out of date,
update it according to current GPT timer driver.
Signed-off-by: Anson Huang <[email protected]>
---
ChangeLog since V3:
be more specific about the backwards compatible of each SoC;
---
.../devicetree/bindings/timer/fsl,imxgpt.txt | 39 ++++++++++++++++++----
1 file changed, 33 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/timer/fsl,imxgpt.txt b/Documentation/devicetree/bindings/timer/fsl,imxgpt.txt
index 9809b11..5d8fd5b 100644
--- a/Documentation/devicetree/bindings/timer/fsl,imxgpt.txt
+++ b/Documentation/devicetree/bindings/timer/fsl,imxgpt.txt
@@ -2,17 +2,44 @@ Freescale i.MX General Purpose Timer (GPT)
Required properties:
-- compatible : should be "fsl,<soc>-gpt"
-- reg : Specifies base physical address and size of the registers.
-- interrupts : A list of 4 interrupts; one per timer channel.
-- clocks : The clocks provided by the SoC to drive the timer.
+- compatible : should be one of following:
+ for i.MX1:
+ - "fsl,imx1-gpt";
+ for i.MX21:
+ - "fsl,imx21-gpt";
+ for i.MX27:
+ - "fsl,imx27-gpt", "fsl,imx21-gpt";
+ for i.MX31:
+ - "fsl,imx31-gpt";
+ for i.MX25:
+ - "fsl,imx25-gpt", "fsl,imx31-gpt";
+ for i.MX50:
+ - "fsl,imx50-gpt", "fsl,imx31-gpt";
+ for i.MX51:
+ - "fsl,imx51-gpt", "fsl,imx31-gpt";
+ for i.MX53:
+ - "fsl,imx53-gpt", "fsl,imx31-gpt";
+ for i.MX6Q:
+ - "fsl,imx6q-gpt", "fsl,imx31-gpt";
+ for i.MX6DL:
+ - "fsl,imx6dl-gpt";
+ for i.MX6SL:
+ - "fsl,imx6sl-gpt", "fsl,imx6dl-gpt";
+ for i.MX6SX:
+ - "fsl,imx6sx-gpt", "fsl,imx6dl-gpt";
+- reg : specifies base physical address and size of the registers.
+- interrupts : should be the gpt interrupt.
+- clocks : the clocks provided by the SoC to drive the timer, must contain
+ an entry for each entry in clock-names.
+- clock-names : must include "ipg" entry first, then "per" entry.
Example:
gpt1: timer@10003000 {
- compatible = "fsl,imx27-gpt", "fsl,imx1-gpt";
+ compatible = "fsl,imx27-gpt", "fsl,imx21-gpt";
reg = <0x10003000 0x1000>;
interrupts = <26>;
- clocks = <&clks 46>, <&clks 61>;
+ clocks = <&clks IMX27_CLK_GPT1_IPG_GATE>,
+ <&clks IMX27_CLK_PER1_GATE>;
clock-names = "ipg", "per";
};
--
2.7.4
On Sat, Dec 29, 2018 at 09:39:34AM +0000, Anson Huang wrote:
> The i.MX GPT timer driver binding doc is out of date,
> update it according to current GPT timer driver.
>
> Signed-off-by: Anson Huang <[email protected]>
> ---
> ChangeLog since V3:
> be more specific about the backwards compatible of each SoC;
> ---
> .../devicetree/bindings/timer/fsl,imxgpt.txt | 39 ++++++++++++++++++----
> 1 file changed, 33 insertions(+), 6 deletions(-)
This now seems in line with my 9+ year old memory of the lineage of this
block. :)
Reviewed-by: Rob Herring <[email protected]>
Rob
Hi, Rob
Best Regards!
Anson Huang
> -----Original Message-----
> From: Rob Herring [mailto:[email protected]]
> Sent: 2019??1??11?? 22:52
> To: Anson Huang <[email protected]>
> Cc: [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; dl-linux-imx
> <[email protected]>
> Subject: Re: [PATCH V4] dt-bindings: timer: gpt: update binding doc
>
> On Sat, Dec 29, 2018 at 09:39:34AM +0000, Anson Huang wrote:
> > The i.MX GPT timer driver binding doc is out of date, update it
> > according to current GPT timer driver.
> >
> > Signed-off-by: Anson Huang <[email protected]>
> > ---
> > ChangeLog since V3:
> > be more specific about the backwards compatible of each SoC;
> > ---
> > .../devicetree/bindings/timer/fsl,imxgpt.txt | 39 ++++++++++++++++++--
> --
> > 1 file changed, 33 insertions(+), 6 deletions(-)
>
> This now seems in line with my 9+ year old memory of the lineage of this
> block. :)
>
> Reviewed-by: Rob Herring <[email protected]>
>
> Rob
Do you know who will pick-up this patch?
Anson
On 18/02/2019 16:17, Anson Huang wrote:
> Hi, Rob
>
> Best Regards!
> Anson Huang
>
>> -----Original Message-----
>> From: Rob Herring [mailto:[email protected]]
>> Sent: 2019??1??11?? 22:52
>> To: Anson Huang <[email protected]>
>> Cc: [email protected]; [email protected]; [email protected];
>> [email protected]; [email protected]; dl-linux-imx
>> <[email protected]>
>> Subject: Re: [PATCH V4] dt-bindings: timer: gpt: update binding doc
>>
>> On Sat, Dec 29, 2018 at 09:39:34AM +0000, Anson Huang wrote:
>>> The i.MX GPT timer driver binding doc is out of date, update it
>>> according to current GPT timer driver.
>>>
>>> Signed-off-by: Anson Huang <[email protected]>
>>> ---
>>> ChangeLog since V3:
>>> be more specific about the backwards compatible of each SoC;
>>> ---
>>> .../devicetree/bindings/timer/fsl,imxgpt.txt | 39 ++++++++++++++++++--
>> --
>>> 1 file changed, 33 insertions(+), 6 deletions(-)
>>
>> This now seems in line with my 9+ year old memory of the lineage of this
>> block. :)
>>
>> Reviewed-by: Rob Herring <[email protected]>
>>
>> Rob
>
> Do you know who will pick-up this patch?
I will. Applied for 5.1
Thanks
-- Daniel
--
<http://www.linaro.org/> Linaro.org ?? Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog