2020-04-13 05:44:06

by Masahiro Yamada

Subject: [PATCH] arc: ptrace: hard-code "arc" instead of UTS_MACHINE

ARC uses the UTS_MACHINE defined in the top Makefile as follows:

UTS_MACHINE := $(ARCH)

We know it is "arc" when we are building the kernel for ARC.
Hard-code user_regset_view::name, like many other architectures do.

Signed-off-by: Masahiro Yamada <[email protected]>
---

arch/arc/kernel/Makefile | 3 ---
arch/arc/kernel/ptrace.c | 2 +-
2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/arch/arc/kernel/Makefile b/arch/arc/kernel/Makefile
index 75539670431a..8c4fc4b54c14 100644
--- a/arch/arc/kernel/Makefile
+++ b/arch/arc/kernel/Makefile
@@ -3,9 +3,6 @@
# Copyright (C) 2004, 2007-2010, 2011-2012 Synopsys, Inc. (http://www.synopsys.com)
#

-# Pass UTS_MACHINE for user_regset definition
-CFLAGS_ptrace.o += -DUTS_MACHINE='"$(UTS_MACHINE)"'
-
obj-y := arcksyms.o setup.o irq.o reset.o ptrace.o process.o devtree.o
obj-y += signal.o traps.o sys.o troubleshoot.o stacktrace.o disasm.o
obj-$(CONFIG_ISA_ARCOMPACT) += entry-compact.o intc-compact.o
diff --git a/arch/arc/kernel/ptrace.c b/arch/arc/kernel/ptrace.c
index d5f3fcf273b5..f49a054a1016 100644
--- a/arch/arc/kernel/ptrace.c
+++ b/arch/arc/kernel/ptrace.c
@@ -253,7 +253,7 @@ static const struct user_regset arc_regsets[] = {
};

static const struct user_regset_view user_arc_view = {
- .name = UTS_MACHINE,
+ .name = "arc",
.e_machine = EM_ARC_INUSE,
.regsets = arc_regsets,
.n = ARRAY_SIZE(arc_regsets)
--
2.25.1

2020-04-13 08:58:25

by Vineet Gupta

Subject: Re: [PATCH] arc: ptrace: hard-code "arc" instead of UTS_MACHINE

Hi Masahiro San,

On 4/12/20 6:32 PM, Masahiro Yamada wrote:
> ARC uses the UTS_MACHINE defined in the top Makefile as follows:
>
> UTS_MACHINE := $(ARCH)
>
> We know it is "arc" when we are building the kernel for ARC.
> Hard-code user_regset_view::name, like many other architectures do.
>
> Signed-off-by: Masahiro Yamada <[email protected]>

Thx for this. Applied to for-curr.

-Vineet