2019-10-15 13:13:13

by Alain Volmat

[permalink] [raw]
Subject: [PATCH v2] i2c: i2c-stm32f7: remove warning when compiling with W=1

Remove the following warning:

drivers/i2c/busses/i2c-stm32f7.c:315:
warning: cannot understand function prototype:
'struct stm32f7_i2c_spec i2c_specs[] =

Replace a comment starting with /** by simply /* to avoid having
it interpreted as a kernel-doc comment.

Fixes: aeb068c57214 ("i2c: i2c-stm32f7: add driver")
Signed-off-by: Alain Volmat <[email protected]>
---
Changes in v2: update commit description
---
drivers/i2c/busses/i2c-stm32f7.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
index d36cf08461f7..7aa4a47792a7 100644
--- a/drivers/i2c/busses/i2c-stm32f7.c
+++ b/drivers/i2c/busses/i2c-stm32f7.c
@@ -305,7 +305,7 @@ struct stm32f7_i2c_dev {
struct regmap *regmap;
};

-/**
+/*
* All these values are coming from I2C Specification, Version 6.0, 4th of
* April 2014.
*
--
2.7.4


2019-10-22 14:05:39

by Pierre-Yves MORDRET

[permalink] [raw]
Subject: Re: [PATCH v2] i2c: i2c-stm32f7: remove warning when compiling with W=1

Hello

Looks good

Reviewed-by: Pierre-Yves MORDRET <[email protected]>

Thx
Regards

On 10/15/19 3:11 PM, Alain Volmat wrote:
> Remove the following warning:
>
> drivers/i2c/busses/i2c-stm32f7.c:315:
> warning: cannot understand function prototype:
> 'struct stm32f7_i2c_spec i2c_specs[] =
>
> Replace a comment starting with /** by simply /* to avoid having
> it interpreted as a kernel-doc comment.
>
> Fixes: aeb068c57214 ("i2c: i2c-stm32f7: add driver")
> Signed-off-by: Alain Volmat <[email protected]>
> ---
> Changes in v2: update commit description
> ---
> drivers/i2c/busses/i2c-stm32f7.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
> index d36cf08461f7..7aa4a47792a7 100644
> --- a/drivers/i2c/busses/i2c-stm32f7.c
> +++ b/drivers/i2c/busses/i2c-stm32f7.c
> @@ -305,7 +305,7 @@ struct stm32f7_i2c_dev {
> struct regmap *regmap;
> };
>
> -/**
> +/*
> * All these values are coming from I2C Specification, Version 6.0, 4th of
> * April 2014.
> *
>

2019-10-25 18:52:44

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH v2] i2c: i2c-stm32f7: remove warning when compiling with W=1

On Tue, Oct 15, 2019 at 03:11:58PM +0200, Alain Volmat wrote:
> Remove the following warning:
>
> drivers/i2c/busses/i2c-stm32f7.c:315:
> warning: cannot understand function prototype:
> 'struct stm32f7_i2c_spec i2c_specs[] =
>
> Replace a comment starting with /** by simply /* to avoid having
> it interpreted as a kernel-doc comment.
>
> Fixes: aeb068c57214 ("i2c: i2c-stm32f7: add driver")
> Signed-off-by: Alain Volmat <[email protected]>

Applied to for-current, thanks!


Attachments:
(No filename) (498.00 B)
signature.asc (849.00 B)
Download all attachments