2018-03-09 05:44:51

by Gustavo A. R. Silva

Subject: [PATCH] pktgen: Remove VLA usage

In preparation to enabling -Wvla, remove VLA usage and replace it
with a fixed-length array instead.

Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
David,

I'm not sure how often this function is being called and,
depending on the frequency it may be worth to use
dynamic memory allocation instead?

Thanks
--
Gustavo

net/core/pktgen.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index d81bddd..e2d6ae3 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -907,7 +907,7 @@ static ssize_t pktgen_if_write(struct file *file,

if (debug) {
size_t copy = min_t(size_t, count, 1023);
- char tb[copy + 1];
+ char tb[1024];
if (copy_from_user(tb, user_buffer, copy))
return -EFAULT;
tb[copy] = 0;
--
2.7.4

2018-03-09 16:59:48

by David Miller

Subject: Re: [PATCH] pktgen: Remove VLA usage

From: "Gustavo A. R. Silva" <[email protected]>
Date: Thu, 8 Mar 2018 23:43:40 -0600

> In preparation to enabling -Wvla, remove VLA usage and replace it
> with a fixed-length array instead.
>
> Signed-off-by: Gustavo A. R. Silva <[email protected]>
> ---
> David,
>
> I'm not sure how often this function is being called and,
> depending on the frequency it may be worth to use
> dynamic memory allocation instead?

It happens every time a config setting is made via the sysfs
files when debug is enabled.

This is not something that happens often.

So your patch is fine, applied to net-next, thanks.

2018-03-09 18:34:53

by Gustavo A. R. Silva

Subject: Re: [PATCH] pktgen: Remove VLA usage

On 03/09/2018 10:58 AM, David Miller wrote:
> From: "Gustavo A. R. Silva" <[email protected]>
> Date: Thu, 8 Mar 2018 23:43:40 -0600
>
>> In preparation to enabling -Wvla, remove VLA usage and replace it
>> with a fixed-length array instead.
>>
>> Signed-off-by: Gustavo A. R. Silva <[email protected]>
>> ---
>> David,
>>
>> I'm not sure how often this function is being called and,
>> depending on the frequency it may be worth to use
>> dynamic memory allocation instead?
>
> It happens every time a config setting is made via the sysfs
> files when debug is enabled.
>
> This is not something that happens often.
>

I got it.

> So your patch is fine, applied to net-next, thanks.
>

Awesome.

Thanks, David.
--
Gustavo