2024-04-10 16:40:20

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH RESEND v8 02/10] watchdog: rzg2l_wdt: Make the driver depend on PM

On Wed, Apr 10, 2024 at 04:40:36PM +0300, Claudiu wrote:
> From: Claudiu Beznea <[email protected]>
>
> The rzg2l_wdt watchdog driver cannot work w/o CONFIG_PM=y (e.g. the
> clocks are enabled though pm_runtime_* specific APIs). To avoid building
> a driver that doesn't work make explicit the dependency on CONFIG_PM.
>
> Suggested-by: Guenter Roeck <[email protected]>
> Signed-off-by: Claudiu Beznea <[email protected]>
> Reviewed-by: Geert Uytterhoeven <[email protected]>

Reviewed-by: Guenter Roeck <[email protected]>

> ---
>
> Changes in v8:
> - collected tags
>
> Changes in v7:
> - updated the dependency to PM || COMPILE_TEST to be able to
> compile-test the driver when compiling for a
> !(ARCH_RZG2L || ARCH_R9A09G011) platform and CONFIG_PM is disabled
>
> Changes in v6:
> - update patch description
> - fixed the dependency on COMPILE_TEST previously introduced
>
> Changes in v5:
> - updated patch description
> - added on a new line the dependency on PM and COMPILE_TEST
>
> Changes in v4:
> - s/ARCH_RENESAS/ARCH_RZG2L || ARCH_R9A09G011 due to patch 1/9
>
> Changes in v3:
> - make driver depend on PM; with that the "unmet direct dependency"
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/linux-devicetree/[email protected]
> was also fixed
> - adapt commit message
>
> Changes in v2:
> - this patch is new
>
> drivers/watchdog/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index e2439967417a..7b66fe06ac85 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -921,6 +921,7 @@ config RENESAS_RZN1WDT
> config RENESAS_RZG2LWDT
> tristate "Renesas RZ/G2L WDT Watchdog"
> depends on ARCH_RZG2L || ARCH_R9A09G011 || COMPILE_TEST
> + depends on PM || COMPILE_TEST
> select WATCHDOG_CORE
> help
> This driver adds watchdog support for the integrated watchdogs in the
> --
> 2.39.2
>