2024-03-27 18:04:19

by Krzysztof Kozlowski

Subject: [PATCH] ata: pata_macio: drop driver owner assignment

PCI core in pci_register_driver() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/ata/pata_macio.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/ata/pata_macio.c b/drivers/ata/pata_macio.c
index 4ac854f6b057..88b2e9817f49 100644
--- a/drivers/ata/pata_macio.c
+++ b/drivers/ata/pata_macio.c
@@ -1371,9 +1371,6 @@ static struct pci_driver pata_macio_pci_driver = {
.suspend = pata_macio_pci_suspend,
.resume = pata_macio_pci_resume,
#endif
- .driver = {
- .owner = THIS_MODULE,
- },
};
MODULE_DEVICE_TABLE(pci, pata_macio_pci_match);

--
2.34.1

2024-03-27 18:28:43

by Sergey Shtylyov

Subject: Re: [PATCH] ata: pata_macio: drop driver owner assignment

Well, strictly speaking, it's initializer, not assignment...

MBR, Sergey

2024-03-27 18:44:13

by Sergey Shtylyov

Subject: Re: [PATCH] ata: pata_macio: drop driver owner assignment

On 3/27/24 8:49 PM, Krzysztof Kozlowski wrote:

> PCI core in pci_register_driver() already sets the .owner, so driver
> does not need to.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Reviewed-by: Sergey Shtylyov <[email protected]>

[...]

MBR, Sergey

2024-03-28 00:17:42

by Damien Le Moal

Subject: Re: [PATCH] ata: pata_macio: drop driver owner assignment

On 3/28/24 02:49, Krzysztof Kozlowski wrote:
> PCI core in pci_register_driver() already sets the .owner, so driver
> does not need to.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Applied to for-6.9-fixes. Thanks !

--
Damien Le Moal
Western Digital Research