2022-05-09 10:28:22

by CGEL

Subject: [PATCH] iio: adc: fix return error variable

From: Lv Ruyi <[email protected]>

Return irq instead of ret which always equals to zero here.

Fixes: d5c70627a794 ("iio: adc: Add Xilinx AMS driver")
Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Lv Ruyi <[email protected]>
---
drivers/iio/adc/xilinx-ams.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/adc/xilinx-ams.c b/drivers/iio/adc/xilinx-ams.c
index a55396c1f8b2..a7687706012d 100644
--- a/drivers/iio/adc/xilinx-ams.c
+++ b/drivers/iio/adc/xilinx-ams.c
@@ -1409,7 +1409,7 @@ static int ams_probe(struct platform_device *pdev)

irq = platform_get_irq(pdev, 0);
if (irq < 0)
- return ret;
+ return irq;

ret = devm_request_irq(&pdev->dev, irq, &ams_irq, 0, "ams-irq",
indio_dev);
--
2.25.1

2022-05-09 10:33:10

by Michal Simek

Subject: Re: [PATCH] iio: adc: fix return error variable

On 5/9/22 09:24, [email protected] wrote:
> From: Lv Ruyi <[email protected]>
>
> Return irq instead of ret which always equals to zero here.
>
> Fixes: d5c70627a794 ("iio: adc: Add Xilinx AMS driver")
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Lv Ruyi <[email protected]>
> ---
> drivers/iio/adc/xilinx-ams.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/xilinx-ams.c b/drivers/iio/adc/xilinx-ams.c
> index a55396c1f8b2..a7687706012d 100644
> --- a/drivers/iio/adc/xilinx-ams.c
> +++ b/drivers/iio/adc/xilinx-ams.c
> @@ -1409,7 +1409,7 @@ static int ams_probe(struct platform_device *pdev)
>
> irq = platform_get_irq(pdev, 0);
> if (irq < 0)
> - return ret;
> + return irq;
>
> ret = devm_request_irq(&pdev->dev, irq, &ams_irq, 0, "ams-irq",
> indio_dev);

Reviewed-by: Michal Simek <[email protected]>

Thanks,
Michal

2022-05-14 21:25:27

by Jonathan Cameron

Subject: Re: [PATCH] iio: adc: fix return error variable

On Mon, 9 May 2022 09:34:57 +0200
Michal Simek <[email protected]> wrote:

> On 5/9/22 09:24, [email protected] wrote:
> > From: Lv Ruyi <[email protected]>

Applied, with modified patch title. There are a lot of ADC drivers
so you should include the name of the driver in the patch description.

iio: adc: xilinx-ams: fix return error variable
> >
> > Return irq instead of ret which always equals to zero here.
> >
> > Fixes: d5c70627a794 ("iio: adc: Add Xilinx AMS driver")
> > Reported-by: Zeal Robot <[email protected]>
> > Signed-off-by: Lv Ruyi <[email protected]>
> > ---
> > drivers/iio/adc/xilinx-ams.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/adc/xilinx-ams.c b/drivers/iio/adc/xilinx-ams.c
> > index a55396c1f8b2..a7687706012d 100644
> > --- a/drivers/iio/adc/xilinx-ams.c
> > +++ b/drivers/iio/adc/xilinx-ams.c
> > @@ -1409,7 +1409,7 @@ static int ams_probe(struct platform_device *pdev)
> >
> > irq = platform_get_irq(pdev, 0);
> > if (irq < 0)
> > - return ret;
> > + return irq;
> >
> > ret = devm_request_irq(&pdev->dev, irq, &ams_irq, 0, "ams-irq",
> > indio_dev);
>
> Reviewed-by: Michal Simek <[email protected]>
>
> Thanks,
> Michal