Commit bae4500399c4 ("[media] exynos4-is: Add missing entity function
initialization") tried to suppress the warnings such as
s5p-fimc-md camera: Entity type for entity FIMC.0 was not initialized!
However, this missed setting for the subdev. Set it now to avoid the
ugly warnings on boot.
Signed-off-by: Jonathan Bakker <[email protected]>
---
Changes from v1:
- Don't remove the function from the vfd entity as it is distinct
from the sd entity
- Re-word commit message for above change
---
drivers/media/platform/exynos4-is/fimc-capture.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/exynos4-is/fimc-capture.c b/drivers/media/platform/exynos4-is/fimc-capture.c
index 705f182330ca..82f051f6b816 100644
--- a/drivers/media/platform/exynos4-is/fimc-capture.c
+++ b/drivers/media/platform/exynos4-is/fimc-capture.c
@@ -1898,6 +1898,7 @@ int fimc_initialize_capture_subdev(struct fimc_dev *fimc)
return ret;
sd->entity.ops = &fimc_sd_media_ops;
+ sd->entity.function = MEDIA_ENT_F_PROC_VIDEO_SCALER;
sd->internal_ops = &fimc_capture_sd_internal_ops;
v4l2_set_subdevdata(sd, fimc);
return 0;
--
2.20.1
On 31.07.2020 01:01, Jonathan Bakker wrote:
> Commit bae4500399c4 ("[media] exynos4-is: Add missing entity function
> initialization") tried to suppress the warnings such as
>
> s5p-fimc-md camera: Entity type for entity FIMC.0 was not initialized!
>
> However, this missed setting for the subdev. Set it now to avoid the
> ugly warnings on boot.
>
> Signed-off-by: Jonathan Bakker <[email protected]>
Reviewed-by: Sylwester Nawrocki <[email protected]>