2024-02-23 01:10:03

by Jeff Johnson

Subject: [PATCH] accel/qaic: Constify aic100_channels

MHI allows the channel configs to be const, so constify
aic100_channels to prevent runtime modification.

Signed-off-by: Jeff Johnson <[email protected]>
---
drivers/accel/qaic/mhi_controller.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/accel/qaic/mhi_controller.c b/drivers/accel/qaic/mhi_controller.c
index cb77d048ed54..3f81d6396c85 100644
--- a/drivers/accel/qaic/mhi_controller.c
+++ b/drivers/accel/qaic/mhi_controller.c
@@ -20,7 +20,7 @@ static unsigned int mhi_timeout_ms = 2000; /* 2 sec default */
module_param(mhi_timeout_ms, uint, 0600);
MODULE_PARM_DESC(mhi_timeout_ms, "MHI controller timeout value");

-static struct mhi_channel_config aic100_channels[] = {
+static const struct mhi_channel_config aic100_channels[] = {
{
.name = "QAIC_LOOPBACK",
.num = 0,

---
base-commit: 3ab6aff5793c3c7bdf6535d9b0024544a4abbdd5
change-id: 20240222-mhi-const-accel-qaic-3889157be7ac

2024-02-23 15:13:25

by Jeffrey Hugo

Subject: Re: [PATCH] accel/qaic: Constify aic100_channels

On 2/22/2024 6:06 PM, Jeff Johnson wrote:
> MHI allows the channel configs to be const, so constify
> aic100_channels to prevent runtime modification.
>
> Signed-off-by: Jeff Johnson <[email protected]>

Reviewed-by: Jeffrey Hugo <[email protected]>

I plan to apply to drm-misc-next before the rc6 freeze.

2024-02-23 16:10:10

by Jeffrey Hugo

Subject: Re: [PATCH] accel/qaic: Constify aic100_channels

On 2/22/2024 6:06 PM, Jeff Johnson wrote:
> MHI allows the channel configs to be const, so constify
> aic100_channels to prevent runtime modification.
>
> Signed-off-by: Jeff Johnson <[email protected]>

Applied to drm-misc-next

-Jeff