2024-01-04 08:56:31

by CK Hu (胡俊光)

[permalink] [raw]
Subject: Re: [PATCH] drm/mediatek/dp: Add the HDCP feature for DisplayPort

Hi, Mac:

On Fri, 2023-11-24 at 16:53 +0800, mac.shen wrote:
> Add tee client application, HDCP 1.x and 2.x authentication for
> DisplayPort
> to support the HDCP feature.
>
> Signed-off-by: mac.shen <[email protected]>
> ---

[snip]

> +
> +enum ENUM_HDCP2_MSG_LIST {
> + HDCP2_MSG_ZERO = 0,
> + HDCP2_MSG_AKE_INIT = 1,
> + HDCP2_MSG_AKE_SEND_CERT = 2,
> + HDCP2_MSG_AKE_NO_STORED_KM = 3,
> + HDCP2_MSG_AKE_STORED_KM = 4,
> + HDCP2_MSG_AKE_SEND_H_PRIME = 5,
> + HDCP2_MSG_AKE_SEND_PAIRING_INFO = 6,
> + HDCP2_MSG_LC_INIT = 7,

This looks like HDCP_2_2_LC_INIT in include/drm/drm_hdcp.h. If these
are defined in HDCP specification, move these definition to
include/drm/drm_hdcp.h

Regards,
CK

> + HDCP2_MSG_LC_SEND_L_PRIME = 8,
> + HDCP2_MSG_SKE_SEND_EKS = 9,
> + HDCP2_MSG_REPAUTH_SEND_RECVID_LIST = 10,
> + HDCP2_MSG_REPAUTH_VERIFY_RECVID_LIST = 11,
> + HDCP2_MSG_REPAUTH_SEND_ACK = 12,
> + HDCP2_MSG_REPAUTH_STREAM_MANAGE = 13,
> + HDCP2_MSG_REPAUTH_STREAM_READY = 14,
> + HDCP2_MSG_AUTH_FAIL = 15,
> + HDCP2_MSG_AUTH_DONE = 16,
> +};