2023-06-14 14:28:35

by Teresa Remmet

Subject: [PATCH] regulator: pca9450: Fix LDO3OUT and LDO4OUT MASK

L3_OUT and L4_OUT Bit fields range from Bit 0:4 and thus the
mask should be 0x1F instead of 0x0F.

Fixes: 0935ff5f1f0a ("regulator: pca9450: add pca9450 pmic driver")
Signed-off-by: Teresa Remmet <[email protected]>
---
include/linux/regulator/pca9450.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/regulator/pca9450.h b/include/linux/regulator/pca9450.h
index 3c01c2bf84f5..505c908dbb81 100644
--- a/include/linux/regulator/pca9450.h
+++ b/include/linux/regulator/pca9450.h
@@ -196,11 +196,11 @@ enum {

/* PCA9450_REG_LDO3_VOLT bits */
#define LDO3_EN_MASK 0xC0
-#define LDO3OUT_MASK 0x0F
+#define LDO3OUT_MASK 0x1F

/* PCA9450_REG_LDO4_VOLT bits */
#define LDO4_EN_MASK 0xC0
-#define LDO4OUT_MASK 0x0F
+#define LDO4OUT_MASK 0x1F

/* PCA9450_REG_LDO5_VOLT bits */
#define LDO5L_EN_MASK 0xC0
--
2.25.1

2023-06-19 08:59:23

by Frieder Schrempf

Subject: Re: [PATCH] regulator: pca9450: Fix LDO3OUT and LDO4OUT MASK

On 14.06.23 14:52, Teresa Remmet wrote:
> L3_OUT and L4_OUT Bit fields range from Bit 0:4 and thus the
> mask should be 0x1F instead of 0x0F.
>
> Fixes: 0935ff5f1f0a ("regulator: pca9450: add pca9450 pmic driver")
> Signed-off-by: Teresa Remmet <[email protected]>

Reviewed-by: Frieder Schrempf <[email protected]>

2023-06-19 20:38:30

by Mark Brown

Subject: Re: [PATCH] regulator: pca9450: Fix LDO3OUT and LDO4OUT MASK

On Wed, 14 Jun 2023 14:52:40 +0200, Teresa Remmet wrote:
> L3_OUT and L4_OUT Bit fields range from Bit 0:4 and thus the
> mask should be 0x1F instead of 0x0F.
>
>

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: pca9450: Fix LDO3OUT and LDO4OUT MASK
commit: 7257d930aadcd62d1c7971ab14f3b1126356abdc

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark