2022-03-15 11:57:48

by Borislav Petkov

[permalink] [raw]
Subject: Re: [tip:locking/core 4/5] vmlinux.o: warning: objtool: do_machine_check()+0x419: call to mca_msr_reg() leaves .noinstr.text section

On Mon, Mar 14, 2022 at 07:40:08PM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking/core
> head: cd27ccfc727e99352321c0c75012ab9c5a90321e
> commit: acb13ea0baf8db8d05a3910c06e997c90825faad [4/5] asm-generic/bitops: Always inline all bit manipulation helpers
> config: x86_64-randconfig-a005-20220314 (https://download.01.org/0day-ci/archive/20220314/[email protected]/config)
> compiler: gcc-9 (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0
> reproduce (this is a W=1 build):
> # https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=acb13ea0baf8db8d05a3910c06e997c90825faad
> git remote add tip https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
> git fetch --no-tags tip locking/core
> git checkout acb13ea0baf8db8d05a3910c06e997c90825faad
> # save the config file to linux build tree
> mkdir build_dir
> make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <[email protected]>
>
> All warnings (new ones prefixed by >>):
>
> vmlinux.o: warning: objtool: mce_read_aux()+0x42: call to mca_msr_reg() leaves .noinstr.text section
> >> vmlinux.o: warning: objtool: do_machine_check()+0x419: call to mca_msr_reg() leaves .noinstr.text section
> vmlinux.o: warning: objtool: enter_from_user_mode()+0x4a: call to on_thread_stack() leaves .noinstr.text section
> vmlinux.o: warning: objtool: syscall_enter_from_user_mode()+0x53: call to on_thread_stack() leaves .noinstr.text section
> vmlinux.o: warning: objtool: syscall_enter_from_user_mode_prepare()+0x4a: call to on_thread_stack() leaves .noinstr.text section
> vmlinux.o: warning: objtool: irqentry_enter_from_user_mode()+0x4a: call to on_thread_stack() leaves .noinstr.text section

You need to test tip/ras/core with that .config - not some random
patches inside of locking/core. Fixing the noinstr issues is split into
a couple of patches in locking/core and ras/core.

Thx.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette


2022-03-17 05:11:04

by Chen, Rong A

[permalink] [raw]
Subject: Re: [kbuild-all] Re: [tip:locking/core 4/5] vmlinux.o: warning: objtool: do_machine_check()+0x419: call to mca_msr_reg() leaves .noinstr.text section



On 3/14/2022 8:01 PM, Borislav Petkov wrote:
> On Mon, Mar 14, 2022 at 07:40:08PM +0800, kernel test robot wrote:
>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking/core
>> head: cd27ccfc727e99352321c0c75012ab9c5a90321e
>> commit: acb13ea0baf8db8d05a3910c06e997c90825faad [4/5] asm-generic/bitops: Always inline all bit manipulation helpers
>> config: x86_64-randconfig-a005-20220314 (https://download.01.org/0day-ci/archive/20220314/[email protected]/config)
>> compiler: gcc-9 (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0
>> reproduce (this is a W=1 build):
>> # https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=acb13ea0baf8db8d05a3910c06e997c90825faad
>> git remote add tip https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
>> git fetch --no-tags tip locking/core
>> git checkout acb13ea0baf8db8d05a3910c06e997c90825faad
>> # save the config file to linux build tree
>> mkdir build_dir
>> make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <[email protected]>
>>
>> All warnings (new ones prefixed by >>):
>>
>> vmlinux.o: warning: objtool: mce_read_aux()+0x42: call to mca_msr_reg() leaves .noinstr.text section
>>>> vmlinux.o: warning: objtool: do_machine_check()+0x419: call to mca_msr_reg() leaves .noinstr.text section
>> vmlinux.o: warning: objtool: enter_from_user_mode()+0x4a: call to on_thread_stack() leaves .noinstr.text section
>> vmlinux.o: warning: objtool: syscall_enter_from_user_mode()+0x53: call to on_thread_stack() leaves .noinstr.text section
>> vmlinux.o: warning: objtool: syscall_enter_from_user_mode_prepare()+0x4a: call to on_thread_stack() leaves .noinstr.text section
>> vmlinux.o: warning: objtool: irqentry_enter_from_user_mode()+0x4a: call to on_thread_stack() leaves .noinstr.text section
>
> You need to test tip/ras/core with that .config - not some random
> patches inside of locking/core. Fixing the noinstr issues is split into
> a couple of patches in locking/core and ras/core.
>
> Thx.
>

Hi Borislav,

Thanks for the explanation, should we skip testing the locking/core
branch next time?

Best Regards,
Rong Chen

2022-03-17 13:55:13

by Borislav Petkov

[permalink] [raw]
Subject: Re: [kbuild-all] Re: [tip:locking/core 4/5] vmlinux.o: warning: objtool: do_machine_check()+0x419: call to mca_msr_reg() leaves .noinstr.text section

On March 17, 2022 12:32:32 AM UTC, "Chen, Rong A" <[email protected]> wrote:
>Thanks for the explanation, should we skip testing the locking/core
>branch next time?

Nah, no need to skip it - this "split fix" will go to Linus next week and you can do your regular testing after that like before.

Thx.


--
Sent from a small device: formatting sux and brevity is inevitable.