2017-11-28 20:28:53

by Dennis Dalessandro

[permalink] [raw]
Subject: Re: [PATCH 0/3] RDMA/hns: Bug fixes in hns RoCE driver

On 11/28/2017 2:33 PM, Jason Gunthorpe wrote:
> On Tue, Nov 28, 2017 at 06:50:44PM +0000, Bart Van Assche wrote:
>> On Tue, 2017-11-28 at 11:39 -0700, Jason Gunthorpe wrote:
>>> On Tue, Nov 28, 2017 at 08:20:09AM -0500, Dennis Dalessandro wrote:
>>>> I could resubmit just the series, or you could just pick the 4 driver
>>>> patches from patchworks whatever is easiest.
>>>
>>> I marked them in patchworks, but can you review the commit messages
>>> and make sure you think Linus will see them as rc material too?
>>
>> My understanding is that the rc stage is intended primarily for fixes for
>> bugs introduced during the merge window. For all patches that do not fix
>> bugs introduced during the merge window it should be evaluated carefully
>> whether or not these are important enough to be included in a rc pull request.
>
> Oh? I thought it was more up to the maintainer discretion within some
> limits. Eg I thought we were running rdma more with the 'if it is OK
> for -stable, then it is OK -rc' kind of mentality?

That's always been my understanding.

> eg -rc is for stablization and bugfixing only, and not restricted only
> to bugs introduced in the latest merge window??

Makes no sense to me to have a hard restriction here. Security fixes,
panics, and other serious bugs should certainly qualify. Of course that
is subject to how complex the fix is.

-Denny

From 1585339681967267582@xxx Tue Nov 28 19:35:37 +0000 2017
X-GM-THRID: 1585183540036899465
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread