2024-04-28 13:53:48

by Christophe JAILLET

Subject: [PATCH] wifi: brcmfmac: remove unused niclist structure

struct niclist was added in the initial commit f21fb3ed364b ("Add support
of Cavium Liquidio ethernet adapters").

Apparently it was never used.

So, remove the structure definition now. This saves a few lines of code.

Signed-off-by: Christophe JAILLET <[email protected]>
---
Compile tested only
---
drivers/net/ethernet/cavium/liquidio/octeon_droq.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_droq.c b/drivers/net/ethernet/cavium/liquidio/octeon_droq.c
index 0d6ee30affb9..eef12fdd246d 100644
--- a/drivers/net/ethernet/cavium/liquidio/octeon_droq.c
+++ b/drivers/net/ethernet/cavium/liquidio/octeon_droq.c
@@ -30,11 +30,6 @@
#include "cn23xx_pf_device.h"
#include "cn23xx_vf_device.h"

-struct niclist {
- struct list_head list;
- void *ptr;
-};
-
struct __dispatch {
struct list_head list;
struct octeon_recv_info *rinfo;
--
2.44.0

2024-04-29 13:39:56

by Simon Horman

Subject: Re: [PATCH] wifi: brcmfmac: remove unused niclist structure

On Sun, Apr 28, 2024 at 03:17:04PM +0200, Christophe JAILLET wrote:
> struct niclist was added in the initial commit f21fb3ed364b ("Add support
> of Cavium Liquidio ethernet adapters").
>
> Apparently it was never used.
>
> So, remove the structure definition now. This saves a few lines of code.
>
> Signed-off-by: Christophe JAILLET <[email protected]>
> ---
> Compile tested only

Reviewed-by: Simon Horman <[email protected]>