2024-04-30 10:55:11

by Jayesh Choudhary

[permalink] [raw]
Subject: [PATCH v2 0/3] Fix reg ranges for main_pktdma dma-controller node

The dma-controller node 'main_pktdma' has few memory regions with
wrong sizes.

DMASS0_PKTDMA_RINGRT is marked as 4MB region when it is actually a 2MB
region. Similarly, DMASS0_PKTDMA_TCHANRT is marked as 256KB region but
the actual size is 128KB as shown in TRM in the section for Main Memory
Map (Table 2-1)

Fix these region across AM62, AM62A and AM62P (which is also used in
J722S)

TRM:

AM625: <https://www.ti.com/lit/pdf/spruiv7>
AM62A7: <https://www.ti.com/lit/pdf/spruj16>
AM62P: <https://www.ti.com/lit/pdf/spruj83>
J722S: <https://www.ti.com/lit/zip/sprujb3>

Changelog v1->v2:
- Add main_pktdma node name in commit message for more clarity about the
dma-controller and mention the table for memory map in TRM in each patch.

v1 patch:
<https://lore.kernel.org/all/[email protected]/>

Jayesh Choudhary (3):
arm64: dts: ti: k3-am62-main: Fix the reg-range for main_pktdma
arm64: dts: ti: k3-am62a-main: Fix the reg-range for main_pktdma
arm64: dts: ti: k3-am62p-main: Fix the reg-range for main_pktdma

arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 4 ++--
arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 4 ++--
arch/arm64/boot/dts/ti/k3-am62p-main.dtsi | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)

--
2.25.1



2024-04-30 10:55:17

by Jayesh Choudhary

[permalink] [raw]
Subject: [PATCH v2 2/3] arm64: dts: ti: k3-am62a-main: Fix the reg-range for main_pktdma

For main_pktdma node, the TX Channel Realtime Register region 'tchanrt'
is 128KB and Ring Realtime Register region 'ringrt' is 2MB as shown in
memory map in the TRM[0] (Table 2-1).
So fix ranges for those register regions.

[0]: <https://www.ti.com/lit/pdf/spruj16>

Fixes: 3dad70def7ff ("arm64: dts: ti: k3-am62a-main: Add more peripheral nodes")
Signed-off-by: Jayesh Choudhary <[email protected]>
---
arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
index bf9c2d9c6439..ce4a2f105630 100644
--- a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
@@ -120,8 +120,8 @@ main_pktdma: dma-controller@485c0000 {
compatible = "ti,am64-dmss-pktdma";
reg = <0x00 0x485c0000 0x00 0x100>,
<0x00 0x4a800000 0x00 0x20000>,
- <0x00 0x4aa00000 0x00 0x40000>,
- <0x00 0x4b800000 0x00 0x400000>,
+ <0x00 0x4aa00000 0x00 0x20000>,
+ <0x00 0x4b800000 0x00 0x200000>,
<0x00 0x485e0000 0x00 0x10000>,
<0x00 0x484a0000 0x00 0x2000>,
<0x00 0x484c0000 0x00 0x2000>,
--
2.25.1


2024-04-30 10:55:27

by Jayesh Choudhary

[permalink] [raw]
Subject: [PATCH v2 3/3] arm64: dts: ti: k3-am62p-main: Fix the reg-range for main_pktdma

For main_pktdma node, the TX Channel Realtime Register region 'tchanrt'
is 128KB and Ring Realtime Register region 'ringrt' is 2MB as shown in
memory map in the TRM[0] (Table 2-1).
So fix ranges for those register regions.

[0]: <https://www.ti.com/lit/pdf/spruj83>

Fixes: b5080c7c1f7e ("arm64: dts: ti: k3-am62p: Add nodes for more IPs")
Signed-off-by: Jayesh Choudhary <[email protected]>
---
arch/arm64/boot/dts/ti/k3-am62p-main.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi
index 900d1f9530a2..2b9bc77a0540 100644
--- a/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi
@@ -123,8 +123,8 @@ main_pktdma: dma-controller@485c0000 {
compatible = "ti,am64-dmss-pktdma";
reg = <0x00 0x485c0000 0x00 0x100>,
<0x00 0x4a800000 0x00 0x20000>,
- <0x00 0x4aa00000 0x00 0x40000>,
- <0x00 0x4b800000 0x00 0x400000>,
+ <0x00 0x4aa00000 0x00 0x20000>,
+ <0x00 0x4b800000 0x00 0x200000>,
<0x00 0x485e0000 0x00 0x10000>,
<0x00 0x484a0000 0x00 0x2000>,
<0x00 0x484c0000 0x00 0x2000>,
--
2.25.1


2024-05-02 10:21:35

by Kumar, Udit

[permalink] [raw]
Subject: Re: [PATCH v2 0/3] Fix reg ranges for main_pktdma dma-controller node

Thanks Jayesh

On 4/30/2024 4:22 PM, Jayesh Choudhary wrote:
> The dma-controller node 'main_pktdma' has few memory regions with
> wrong sizes.
>
> DMASS0_PKTDMA_RINGRT is marked as 4MB region when it is actually a 2MB
> region. Similarly, DMASS0_PKTDMA_TCHANRT is marked as 256KB region but
> the actual size is 128KB as shown in TRM in the section for Main Memory
> Map (Table 2-1)
>
> Fix these region across AM62, AM62A and AM62P (which is also used in
> J722S)
>
> TRM:


For series

Reviewed-by: Udit Kumar <[email protected]>


>
> AM625: <https://www.ti.com/lit/pdf/spruiv7>
> AM62A7: <https://www.ti.com/lit/pdf/spruj16>
> AM62P: <https://www.ti.com/lit/pdf/spruj83>
> J722S: <https://www.ti.com/lit/zip/sprujb3>
>
> Changelog v1->v2:
> - Add main_pktdma node name in commit message for more clarity about the
> dma-controller and mention the table for memory map in TRM in each patch.
>
> v1 patch:
> <https://lore.kernel.org/all/[email protected]/>
>
> Jayesh Choudhary (3):
> arm64: dts: ti: k3-am62-main: Fix the reg-range for main_pktdma
> arm64: dts: ti: k3-am62a-main: Fix the reg-range for main_pktdma
> arm64: dts: ti: k3-am62p-main: Fix the reg-range for main_pktdma
>
> arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 4 ++--
> arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 4 ++--
> arch/arm64/boot/dts/ti/k3-am62p-main.dtsi | 4 ++--
> 3 files changed, 6 insertions(+), 6 deletions(-)
>