2020-01-20 14:08:28

by Tom Hebb

Subject: [PATCH v2 2/2] usb: typec: fusb302: fix "op-sink-microwatt" default that was in mW

commit 8f6244055bd3 ("usb: typec: fusb302: Always provide fwnode for the
port") didn't convert this value from mW to uW when migrating to a new
specification format like it should have.

Fixes: 8f6244055bd3 ("usb: typec: fusb302: Always provide fwnode for the port")
Cc: [email protected]
Signed-off-by: Thomas Hebb <[email protected]>

---

Changes in v2: None

drivers/usb/typec/tcpm/fusb302.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
index ed8655c6af8c..b498960ff72b 100644
--- a/drivers/usb/typec/tcpm/fusb302.c
+++ b/drivers/usb/typec/tcpm/fusb302.c
@@ -1666,7 +1666,7 @@ static const struct property_entry port_props[] = {
PROPERTY_ENTRY_STRING("try-power-role", "sink"),
PROPERTY_ENTRY_U32_ARRAY("source-pdos", src_pdo),
PROPERTY_ENTRY_U32_ARRAY("sink-pdos", snk_pdo),
- PROPERTY_ENTRY_U32("op-sink-microwatt", 2500),
+ PROPERTY_ENTRY_U32("op-sink-microwatt", 2500000),
{ }
};

--
2.24.1

2020-01-22 09:10:35

by Greg KH

Subject: Re: [PATCH v2 2/2] usb: typec: fusb302: fix "op-sink-microwatt" default that was in mW

On Mon, Jan 20, 2020 at 06:05:41AM -0800, Thomas Hebb wrote:
> commit 8f6244055bd3 ("usb: typec: fusb302: Always provide fwnode for the
> port") didn't convert this value from mW to uW when migrating to a new
> specification format like it should have.
>
> Fixes: 8f6244055bd3 ("usb: typec: fusb302: Always provide fwnode for the port")
> Cc: [email protected]

Nit, there is no such address :)

2020-01-22 09:13:19

by Heikki Krogerus

Subject: Re: [PATCH v2 2/2] usb: typec: fusb302: fix "op-sink-microwatt" default that was in mW

On Wed, Jan 22, 2020 at 10:08:20AM +0100, Greg Kroah-Hartman wrote:
> On Mon, Jan 20, 2020 at 06:05:41AM -0800, Thomas Hebb wrote:
> > commit 8f6244055bd3 ("usb: typec: fusb302: Always provide fwnode for the
> > port") didn't convert this value from mW to uW when migrating to a new
> > specification format like it should have.
> >
> > Fixes: 8f6244055bd3 ("usb: typec: fusb302: Always provide fwnode for the port")
> > Cc: [email protected]
>
> Nit, there is no such address :)

Thomas already fixed the address in v3.

thanks,

--
heikki

2020-01-22 09:18:03

by Greg KH

Subject: Re: [PATCH v2 2/2] usb: typec: fusb302: fix "op-sink-microwatt" default that was in mW

On Wed, Jan 22, 2020 at 11:12:02AM +0200, Heikki Krogerus wrote:
> On Wed, Jan 22, 2020 at 10:08:20AM +0100, Greg Kroah-Hartman wrote:
> > On Mon, Jan 20, 2020 at 06:05:41AM -0800, Thomas Hebb wrote:
> > > commit 8f6244055bd3 ("usb: typec: fusb302: Always provide fwnode for the
> > > port") didn't convert this value from mW to uW when migrating to a new
> > > specification format like it should have.
> > >
> > > Fixes: 8f6244055bd3 ("usb: typec: fusb302: Always provide fwnode for the port")
> > > Cc: [email protected]
> >
> > Nit, there is no such address :)
>
> Thomas already fixed the address in v3.

Now see that series and queued it up, thanks.

greg k-h