2018-05-04 09:21:36

by Aapo Vienamo

[permalink] [raw]
Subject: [PATCH] mmc: tegra: remove redundant return statement

A redundant return statement is removed from
tegra_sdhci_set_uhs_signaling(). The function returns void and the
return does not affect the control flow of the function.

Signed-off-by: Aapo Vienamo <[email protected]>
---
drivers/mmc/host/sdhci-tegra.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
index b877c13184c2..970d38f68939 100644
--- a/drivers/mmc/host/sdhci-tegra.c
+++ b/drivers/mmc/host/sdhci-tegra.c
@@ -231,7 +231,7 @@ static void tegra_sdhci_set_uhs_signaling(struct sdhci_host *host,
if (timing == MMC_TIMING_UHS_DDR50)
tegra_host->ddr_signaling = true;

- return sdhci_set_uhs_signaling(host, timing);
+ sdhci_set_uhs_signaling(host, timing);
}

static unsigned int tegra_sdhci_get_max_clock(struct sdhci_host *host)
--
2.16.1



2018-05-04 09:27:58

by Thierry Reding

[permalink] [raw]
Subject: Re: [PATCH] mmc: tegra: remove redundant return statement

On Fri, May 04, 2018 at 12:20:53PM +0300, Aapo Vienamo wrote:
> A redundant return statement is removed from
> tegra_sdhci_set_uhs_signaling(). The function returns void and the
> return does not affect the control flow of the function.
>
> Signed-off-by: Aapo Vienamo <[email protected]>
> ---
> drivers/mmc/host/sdhci-tegra.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
> index b877c13184c2..970d38f68939 100644
> --- a/drivers/mmc/host/sdhci-tegra.c
> +++ b/drivers/mmc/host/sdhci-tegra.c
> @@ -231,7 +231,7 @@ static void tegra_sdhci_set_uhs_signaling(struct sdhci_host *host,
> if (timing == MMC_TIMING_UHS_DDR50)
> tegra_host->ddr_signaling = true;
>
> - return sdhci_set_uhs_signaling(host, timing);
> + sdhci_set_uhs_signaling(host, timing);
> }
>
> static unsigned int tegra_sdhci_get_max_clock(struct sdhci_host *host)

Good catch!

Acked-by: Thierry Reding <[email protected]>

Attachments:
(No filename) (1.00 kB)
 signature.asc (849.00 B)
 Download all attachments

2018-05-04 09:52:23

by Adrian Hunter

[permalink] [raw]
Subject: Re: [PATCH] mmc: tegra: remove redundant return statement

On 04/05/18 12:20, Aapo Vienamo wrote:
> A redundant return statement is removed from
> tegra_sdhci_set_uhs_signaling(). The function returns void and the
> return does not affect the control flow of the function.
>
> Signed-off-by: Aapo Vienamo <[email protected]>

Acked-by: Adrian Hunter <[email protected]>

> ---
> drivers/mmc/host/sdhci-tegra.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
> index b877c13184c2..970d38f68939 100644
> --- a/drivers/mmc/host/sdhci-tegra.c
> +++ b/drivers/mmc/host/sdhci-tegra.c
> @@ -231,7 +231,7 @@ static void tegra_sdhci_set_uhs_signaling(struct sdhci_host *host,
> if (timing == MMC_TIMING_UHS_DDR50)
> tegra_host->ddr_signaling = true;
>
> - return sdhci_set_uhs_signaling(host, timing);
> + sdhci_set_uhs_signaling(host, timing);
> }
>
> static unsigned int tegra_sdhci_get_max_clock(struct sdhci_host *host)
>


2018-05-08 09:06:43

by Ulf Hansson

[permalink] [raw]
Subject: Re: [PATCH] mmc: tegra: remove redundant return statement

On 4 May 2018 at 11:20, Aapo Vienamo <[email protected]> wrote:
> A redundant return statement is removed from
> tegra_sdhci_set_uhs_signaling(). The function returns void and the
> return does not affect the control flow of the function.
>
> Signed-off-by: Aapo Vienamo <[email protected]>

Thanks, applied for next!

Kind regards
Uffe

> ---
> drivers/mmc/host/sdhci-tegra.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
> index b877c13184c2..970d38f68939 100644
> --- a/drivers/mmc/host/sdhci-tegra.c
> +++ b/drivers/mmc/host/sdhci-tegra.c
> @@ -231,7 +231,7 @@ static void tegra_sdhci_set_uhs_signaling(struct sdhci_host *host,
> if (timing == MMC_TIMING_UHS_DDR50)
> tegra_host->ddr_signaling = true;
>
> - return sdhci_set_uhs_signaling(host, timing);
> + sdhci_set_uhs_signaling(host, timing);
> }
>
> static unsigned int tegra_sdhci_get_max_clock(struct sdhci_host *host)
> --
> 2.16.1
>