2015-04-19 03:36:08

by Baruch Siach

[permalink] [raw]
Subject: [PATCH] Documentation/CodingStyle: fix example macro parenthesis imbalance

Cc: Bartosz Golaszewski <[email protected]>
Cc: Andrew Morton <[email protected]>
Fixes: f2027543b9 ('documentation: update CodingStyle on local variables naming in macros')
Signed-off-by: Baruch Siach <[email protected]>
---
Documentation/CodingStyle | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle
index f4b78eafd92a..b713c35f8543 100644
--- a/Documentation/CodingStyle
+++ b/Documentation/CodingStyle
@@ -670,7 +670,7 @@ functions:
typeof(x) ret; \
ret = calc_ret(x); \
(ret); \
-)}
+})

ret is a common name for a local variable - __foo_ret is less likely
to collide with an existing variable.
--
2.1.4


2015-05-07 15:52:27

by Jonathan Corbet

[permalink] [raw]
Subject: Re: [PATCH] Documentation/CodingStyle: fix example macro parenthesis imbalance

On Sun, 19 Apr 2015 06:35:01 +0300
Baruch Siach <[email protected]> wrote:

> -)}
> +})

Makes sense. Applied to the docs tree, thanks.

jon