2021-05-19 18:28:46

by Aditya Srivastava

Subject: [PATCH] win_minmax: fix kernel-doc syntax in file header

The opening comment mark '/**' is used for highlighting the beginning of
kernel-doc comments.
The header for include/linux/win_minmax.h follows this syntax, but the
content inside does not comply with kernel-doc.

This line was probably not meant for kernel-doc parsing, but is parsed
due to the presence of kernel-doc like comment syntax(i.e, '/**'), which
causes unexpected warning from kernel-doc:
warning: expecting prototype for c(). Prototype was for MINMAX_H() instead

Provide a simple fix by replacing this occurrence with general comment
format, i.e. '/*', to prevent kernel-doc from parsing it.

Signed-off-by: Aditya Srivastava <[email protected]>
---
* Applies perfectly on next-20210514

include/linux/win_minmax.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/win_minmax.h b/include/linux/win_minmax.h
index 4ca2842d2842..54bd6f133fa6 100644
--- a/include/linux/win_minmax.h
+++ b/include/linux/win_minmax.h
@@ -1,5 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0 */
-/**
+/*
* lib/minmax.c: windowed min/max tracker by Kathleen Nichols.
*
*/
--
2.17.1

2021-05-19 18:32:20

by Randy Dunlap

Subject: Re: [PATCH] win_minmax: fix kernel-doc syntax in file header

On 5/18/21 11:03 AM, Aditya Srivastava wrote:
>
> Provide a simple fix by replacing this occurrence with general comment
> format, i.e. '/*', to prevent kernel-doc from parsing it.
>
> Signed-off-by: Aditya Srivastava <[email protected]>
> ---
> * Applies perfectly on next-20210514
>
> include/linux/win_minmax.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Randy Dunlap <[email protected]>

Thanks.

--
~Randy