2018-07-18 19:57:36

by Krzysztof Kozlowski

Subject: [PATCH] clk: samsung: Remove unused mout_user_aclk400_mcuisp_p4x12 variable

Remove unused 'mout_user_aclk400_mcuisp_p4x12' variable to fix GCC warning:

drivers/clk/samsung/clk-exynos4412-isp.c:40:27: warning:
'mout_user_aclk400_mcuisp_p4x12' defined but not used [-Wunused-const-variable=]

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/clk/samsung/clk-exynos4412-isp.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/clk/samsung/clk-exynos4412-isp.c b/drivers/clk/samsung/clk-exynos4412-isp.c
index d5f1ccb36300..cfaa057035ad 100644
--- a/drivers/clk/samsung/clk-exynos4412-isp.c
+++ b/drivers/clk/samsung/clk-exynos4412-isp.c
@@ -37,8 +37,6 @@ static const unsigned long exynos4x12_clk_isp_save[] __initconst = {
E4X12_GATE_ISP1,
};

-PNAME(mout_user_aclk400_mcuisp_p4x12) = { "fin_pll", "div_aclk400_mcuisp", };
-
static struct samsung_div_clock exynos4x12_isp_div_clks[] = {
DIV(CLK_ISP_DIV_ISP0, "div_isp0", "aclk200", E4X12_DIV_ISP0, 0, 3),
DIV(CLK_ISP_DIV_ISP1, "div_isp1", "aclk200", E4X12_DIV_ISP0, 4, 3),
--
2.14.1

2018-07-18 20:34:00

by Tobias Jakobi

Subject: Re: [PATCH] clk: samsung: Remove unused mout_user_aclk400_mcuisp_p4x12 variable

Speaking of the ISP clocks driver, I wonder why this one was never merged?
https://patches.linaro.org/patch/115531/

- Tobias


Krzysztof Kozlowski wrote:
> Remove unused 'mout_user_aclk400_mcuisp_p4x12' variable to fix GCC warning:
>
> drivers/clk/samsung/clk-exynos4412-isp.c:40:27: warning:
> 'mout_user_aclk400_mcuisp_p4x12' defined but not used [-Wunused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> drivers/clk/samsung/clk-exynos4412-isp.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/clk/samsung/clk-exynos4412-isp.c b/drivers/clk/samsung/clk-exynos4412-isp.c
> index d5f1ccb36300..cfaa057035ad 100644
> --- a/drivers/clk/samsung/clk-exynos4412-isp.c
> +++ b/drivers/clk/samsung/clk-exynos4412-isp.c
> @@ -37,8 +37,6 @@ static const unsigned long exynos4x12_clk_isp_save[] __initconst = {
> E4X12_GATE_ISP1,
> };
>
> -PNAME(mout_user_aclk400_mcuisp_p4x12) = { "fin_pll", "div_aclk400_mcuisp", };
> -
> static struct samsung_div_clock exynos4x12_isp_div_clks[] = {
> DIV(CLK_ISP_DIV_ISP0, "div_isp0", "aclk200", E4X12_DIV_ISP0, 0, 3),
> DIV(CLK_ISP_DIV_ISP1, "div_isp1", "aclk200", E4X12_DIV_ISP0, 4, 3),
>

2018-07-19 06:35:32

by Krzysztof Kozlowski

Subject: Re: [PATCH] clk: samsung: Remove unused mout_user_aclk400_mcuisp_p4x12 variable

On 18 July 2018 at 22:33, Tobias Jakobi <[email protected]> wrote:
> Speaking of the ISP clocks driver, I wonder why this one was never merged?
> https://patches.linaro.org/patch/115531/

Thanks for reminding this!

It seems that Sylwester is out of office so we'll have to wait for reply.

Best regards,
Krzysztof

2018-07-26 15:18:09

by Stephen Boyd

Subject: Re: [PATCH] clk: samsung: Remove unused mout_user_aclk400_mcuisp_p4x12 variable

Quoting Krzysztof Kozlowski (2018-07-18 12:56:20)
> Remove unused 'mout_user_aclk400_mcuisp_p4x12' variable to fix GCC warning:
>
> drivers/clk/samsung/clk-exynos4412-isp.c:40:27: warning:
> 'mout_user_aclk400_mcuisp_p4x12' defined but not used [-Wunused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---

Applied to clk-next