2009-01-28 14:34:21

by Arnaldo Carvalho de Melo

Subject: [PATCH tip 1/1] blktrace: Use tracing_reset_online_cpus

Impact: cleanup

Use tracing_reset_online_cpus instead of open coding it.

Cc: Jens Axboe <[email protected]>
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>

diff --git a/block/blktrace.c b/block/blktrace.c
index 1b2267c..04d81d3 100644
--- a/block/blktrace.c
+++ b/block/blktrace.c
@@ -1109,12 +1109,7 @@ static void blk_tracer_print_header(struct seq_file *m)

static void blk_tracer_start(struct trace_array *tr)
{
- int cpu;
-
- tr->time_start = ftrace_now(tr->cpu);
-
- for_each_online_cpu(cpu)
- tracing_reset(tr, cpu);
+ tracing_reset_online_cpus(tr);

mutex_lock(&blk_probe_mutex);
if (atomic_add_return(1, &blk_probes_ref) == 1)

2009-01-28 14:54:01

by Frederic Weisbecker

Subject: Re: [PATCH tip 1/1] blktrace: Use tracing_reset_online_cpus

2009/1/28 Arnaldo Carvalho de Melo <[email protected]>:
> Impact: cleanup
>
> Use tracing_reset_online_cpus instead of open coding it.
>
> Cc: Jens Axboe <[email protected]>
> Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
>
> diff --git a/block/blktrace.c b/block/blktrace.c
> index 1b2267c..04d81d3 100644
> --- a/block/blktrace.c
> +++ b/block/blktrace.c
> @@ -1109,12 +1109,7 @@ static void blk_tracer_print_header(struct seq_file *m)
>
> static void blk_tracer_start(struct trace_array *tr)
> {
> - int cpu;
> -
> - tr->time_start = ftrace_now(tr->cpu);
> -
> - for_each_online_cpu(cpu)
> - tracing_reset(tr, cpu);
> + tracing_reset_online_cpus(tr);
>
> mutex_lock(&blk_probe_mutex);
> if (atomic_add_return(1, &blk_probes_ref) == 1)
>

Adding Steven in Cc, he uses to relay tracing patches as patchsets
pull request to Ingo.

2009-01-28 14:59:22

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH tip 1/1] blktrace: Use tracing_reset_online_cpus

Em Wed, Jan 28, 2009 at 03:53:48PM +0100, Fr?d?ric Weisbecker escreveu:
> 2009/1/28 Arnaldo Carvalho de Melo <[email protected]>:
> > Impact: cleanup
> >
> > Use tracing_reset_online_cpus instead of open coding it.
> >
> > Cc: Jens Axboe <[email protected]>
> > Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
> >
> > diff --git a/block/blktrace.c b/block/blktrace.c
> > index 1b2267c..04d81d3 100644
> > --- a/block/blktrace.c
> > +++ b/block/blktrace.c
> > @@ -1109,12 +1109,7 @@ static void blk_tracer_print_header(struct seq_file *m)
> >
> > static void blk_tracer_start(struct trace_array *tr)
> > {
> > - int cpu;
> > -
> > - tr->time_start = ftrace_now(tr->cpu);
> > -
> > - for_each_online_cpu(cpu)
> > - tracing_reset(tr, cpu);
> > + tracing_reset_online_cpus(tr);
> >
> > mutex_lock(&blk_probe_mutex);
> > if (atomic_add_return(1, &blk_probes_ref) == 1)
> >
>
> Adding Steven in Cc, he uses to relay tracing patches as patchsets
> pull request to Ingo.

Ok, will add him for the next one.

- Arnaldo

2009-01-29 13:29:18

by Ingo Molnar

Subject: Re: [PATCH tip 1/1] blktrace: Use tracing_reset_online_cpus

* Arnaldo Carvalho de Melo <[email protected]> wrote:

> Impact: cleanup
>
> Use tracing_reset_online_cpus instead of open coding it.
>
> Cc: Jens Axboe <[email protected]>
> Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
>
> diff --git a/block/blktrace.c b/block/blktrace.c
> index 1b2267c..04d81d3 100644

Applied to tip/tracing/blktrace, thanks Arnaldo!

Ingo