2020-05-05 07:49:28

by Jason Yan

Subject: [PATCH net-next] net: agere: use true,false for bool variable

Fix the following coccicheck warning:

drivers/net/ethernet/agere/et131x.c:717:3-22: WARNING: Assignment of
0/1 to bool variable
drivers/net/ethernet/agere/et131x.c:721:1-20: WARNING: Assignment of
0/1 to bool variable

Signed-off-by: Jason Yan <[email protected]>
---
drivers/net/ethernet/agere/et131x.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/agere/et131x.c b/drivers/net/ethernet/agere/et131x.c
index 1b19385ad8a9..865892c1f23f 100644
--- a/drivers/net/ethernet/agere/et131x.c
+++ b/drivers/net/ethernet/agere/et131x.c
@@ -714,11 +714,11 @@ static int et131x_init_eeprom(struct et131x_adapter *adapter)
* gather additional information that normally would
* come from the eeprom, like MAC Address
*/
- adapter->has_eeprom = 0;
+ adapter->has_eeprom = false;
return -EIO;
}
}
- adapter->has_eeprom = 1;
+ adapter->has_eeprom = true;

/* Read the EEPROM for information regarding LED behavior. Refer to
* et131x_xcvr_init() for its use.
--
2.21.1

2020-05-05 08:20:37

by Mark Einon

Subject: Re: [PATCH net-next] net: agere: use true,false for bool variable

On Tue, 2020-05-05 at 15:45 +0800, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> drivers/net/ethernet/agere/et131x.c:717:3-22: WARNING: Assignment of
> 0/1 to bool variable
> drivers/net/ethernet/agere/et131x.c:721:1-20: WARNING: Assignment of
> 0/1 to bool variable
>
> Signed-off-by: Jason Yan <[email protected]>

Acked-by: Mark Einon <[email protected]>

2020-05-05 18:43:10

by David Miller

Subject: Re: [PATCH net-next] net: agere: use true,false for bool variable

From: Jason Yan <[email protected]>
Date: Tue, 5 May 2020 15:45:56 +0800

> Fix the following coccicheck warning:
>
> drivers/net/ethernet/agere/et131x.c:717:3-22: WARNING: Assignment of
> 0/1 to bool variable
> drivers/net/ethernet/agere/et131x.c:721:1-20: WARNING: Assignment of
> 0/1 to bool variable
>
> Signed-off-by: Jason Yan <[email protected]>

Applied.