2020-06-09 16:11:21

by Joe Perches

[permalink] [raw]
Subject: Re: [PATCH 17/17] scripts/spelling.txt: Add descriptors correction

On Tue, 2020-06-09 at 13:46 +0100, Kieran Bingham wrote:
> After coming across the s/decriptors/descriptors/ spelling error twice,
> a scan of the tree showed it was a pervasive mistake.
[]
> diff --git a/scripts/spelling.txt b/scripts/spelling.txt
[]
> @@ -404,6 +404,7 @@ decendants||descendants
> decompres||decompress
> decsribed||described
> decription||description
> +decriptors||descriptors

spelling.txt does not check singular and plural
uses unless each is described separately so please
add the singular one too:

decriptor|descriptor

$ git grep -i -w decriptor | wc -l
18
$ git grep -i -w decriptors | wc -l
12


2020-06-10 09:13:23

by Kieran Bingham

[permalink] [raw]
Subject: Re: [PATCH 17/17] scripts/spelling.txt: Add descriptors correction

Hi Joe,

On 09/06/2020 17:08, Joe Perches wrote:
> On Tue, 2020-06-09 at 13:46 +0100, Kieran Bingham wrote:
>> After coming across the s/decriptors/descriptors/ spelling error twice,
>> a scan of the tree showed it was a pervasive mistake.
> []
>> diff --git a/scripts/spelling.txt b/scripts/spelling.txt
> []
>> @@ -404,6 +404,7 @@ decendants||descendants
>> decompres||decompress
>> decsribed||described
>> decription||description
>> +decriptors||descriptors
>
> spelling.txt does not check singular and plural
> uses unless each is described separately so please
> add the singular one too:
>
> decriptor|descriptor
>
> $ git grep -i -w decriptor | wc -l
> 18
> $ git grep -i -w decriptors | wc -l
> 12

I believe my conversion was based on the non-pluralised version, so I
think I changed all occurences, but then foolishly somehow ended up
using the plural for the commit message, which translated into being the
entry I put in spelling.txt. Sorry ... :-S

I'll fix up, and re-validate any missing fixups after the rebase. I
think I originally did this at about v5.0, and I already picked up a
couple extra when I did the rebase, and now you've highlighted the
plural - I bet I missed some non-plural versions too ;-)

Will re-check and correct.

Thanks.

--
Kieran