2019-03-21 08:06:22

by Yannick FERTRE

[permalink] [raw]
Subject: [PATCH] drm/panel: otm8009a: no error msg if probe deferred

Do not print an error message if the regulator framework
returns EPROBE_DEFER.

Signed-off-by: Yannick Fertré <[email protected]>
---
drivers/gpu/drm/panel/panel-orisetech-otm8009a.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
index 87fa316..aa3db38 100644
--- a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
+++ b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
@@ -433,7 +433,8 @@ static int otm8009a_probe(struct mipi_dsi_device *dsi)
ctx->supply = devm_regulator_get(dev, "power");
if (IS_ERR(ctx->supply)) {
ret = PTR_ERR(ctx->supply);
- dev_err(dev, "failed to request regulator: %d\n", ret);
+ if (ret != -EPROBE_DEFER)
+ dev_err(dev, "failed to request regulator: %d\n", ret);
return ret;
}

--
2.7.4



2019-03-26 12:51:10

by Philippe Cornu

[permalink] [raw]
Subject: Re: [PATCH] drm/panel: otm8009a: no error msg if probe deferred

Dear Yannick,
Many thanks for your patch.

Reviewed-by: Philippe Cornu <[email protected]>
Tested-by: Philippe Cornu <[email protected]>

Philippe :-)


On 3/21/19 9:04 AM, Yannick Fertré wrote:
> Do not print an error message if the regulator framework
> returns EPROBE_DEFER.
>
> Signed-off-by: Yannick Fertré <[email protected]>
> ---
> drivers/gpu/drm/panel/panel-orisetech-otm8009a.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
> index 87fa316..aa3db38 100644
> --- a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
> +++ b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
> @@ -433,7 +433,8 @@ static int otm8009a_probe(struct mipi_dsi_device *dsi)
> ctx->supply = devm_regulator_get(dev, "power");
> if (IS_ERR(ctx->supply)) {
> ret = PTR_ERR(ctx->supply);
> - dev_err(dev, "failed to request regulator: %d\n", ret);
> + if (ret != -EPROBE_DEFER)
> + dev_err(dev, "failed to request regulator: %d\n", ret);
> return ret;
> }
>
>

2019-04-03 16:25:39

by Thierry Reding

[permalink] [raw]
Subject: Re: [PATCH] drm/panel: otm8009a: no error msg if probe deferred

On Thu, Mar 21, 2019 at 09:04:44AM +0100, Yannick Fertré wrote:
> Do not print an error message if the regulator framework
> returns EPROBE_DEFER.
>
> Signed-off-by: Yannick Fertré <[email protected]>
> ---
> drivers/gpu/drm/panel/panel-orisetech-otm8009a.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)

Applied, thanks.

Thierry

Attachments:
(No filename) (363.00 B)
 signature.asc (849.00 B)
 Download all attachments