2017-11-30 14:14:16

by Arvind Yadav

[permalink] [raw]
Subject: [PATCH] gpio: ftgpio010: Fix platform_get_irq's error checking

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/gpio/gpio-ftgpio010.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-ftgpio010.c b/drivers/gpio/gpio-ftgpio010.c
index 7b3394f..feff86a 100644
--- a/drivers/gpio/gpio-ftgpio010.c
+++ b/drivers/gpio/gpio-ftgpio010.c
@@ -176,8 +176,8 @@ static int ftgpio_gpio_probe(struct platform_device *pdev)
return PTR_ERR(g->base);

irq = platform_get_irq(pdev, 0);
- if (!irq)
- return -EINVAL;
+ if (irq < 0)
+ return irq;

ret = bgpio_init(&g->gc, dev, 4,
g->base + GPIO_DATA_IN,
--
2.7.4


From 1587226707062984182@xxx Tue Dec 19 15:29:04 +0000 2017
X-GM-THRID: 1585848737230345964
X-Gmail-Labels: Inbox,Category Forums